microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.4k stars 29.33k forks source link

After VSC upgrade source control diff inline does not show old lines #198078

Closed crystalfp closed 10 months ago

crystalfp commented 1 year ago

Type: Bug

  1. Modify a line in package.json
  2. Click on package.json line in source control
  3. The inline view show only the new line, not the old one
  4. Instead, the split view show both lines. This problem does not happens with all files of the project, only some of them.

VS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:51:52.184Z) OS version: Windows_NT x64 10.0.22631 Modes:

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2592)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|31.77GB (11.77GB free)| |Process Argv|D:\\Projects\\IIE\\IIE.code-workspace --crash-reporter-id df3b806e-c371-4e03-89b8-d13088946634| |Screen Reader|no| |VM|0%|
Extensions (70) Extension|Author (truncated)|Version ---|---|--- vscode-openapi|42C|4.18.6 Bookmarks|ale|13.4.2 appmap|app|0.103.0 vscode-file-templates|bam|1.1.0 github-markdown-preview|bie|0.3.0 markdown-footnotes|bie|0.1.1 markdown-mermaid|bie|1.20.0 markdown-yaml-preamble|bie|0.1.0 vscode-toggle-quotes|Bri|0.3.6 vscode-pandoc|Chr|0.4.5 refactorix|chr|0.3.7 markdown-word-count|Cur|0.0.6 vscode-eslint|dba|2.4.2 eslint-disable-snippets|drK|1.4.1 vscode-great-icons|emm|2.1.102 vscode-todo-plus|fab|4.19.1 auto-close-tag|for|0.5.14 todo-tree|Gru|0.0.226 plantuml|jeb|2.17.5 code-eol|jef|1.0.12 vscode-peacock|joh|4.2.2 jsdoc-generator|kim|0.0.4 tag-rename|kri|0.2.1 stack-tabs|kyl|0.0.2 git-graph|mhu|1.30.0 prettify-json|moh|0.0.3 tab-cycle|mpo|1.0.1 isort|ms-|2023.10.1 python|ms-|2023.20.0 vscode-pylance|ms-|2023.11.10 jupyter|ms-|2023.10.1003070148 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.17 vscode-jupyter-cell-tags|ms-|0.1.8 vscode-jupyter-slideshow|ms-|0.1.5 hexeditor|ms-|1.9.12 notepadplusplus-keybindings|ms-|1.0.7 color-highlight|nau|2.5.0 gremlins|nho|0.26.0 abracadabra|nic|9.0.2 pandocciter|not|0.10.3 leaper|Onl|0.10.5 vscode-jscpd|pau|0.3.4 bib|phr|0.3.0 git-file-history|pom|1.0.1 vscode-thunder-client|ran|2.15.3 vscode-yaml|red|1.14.0 pandoc-markdown|rso|0.1.2 vscode-javascript-booster|sbu|14.0.1 trailing-spaces|sha|0.4.1 markdown-preview-enhanced|shd|0.8.10 vscode-scss-formatter|sib|3.0.0 vscode-autohide|sir|1.0.8 stardog-rdf-grammars|sta|0.2.1 code-spell-checker|str|3.0.1 code-spell-checker-italian|str|1.1.0 unique-window-colors|stu|1.0.51 vscode-stylelint|sty|1.3.0 sass-indented|syl|1.8.28 open-in-browser|tec|2.0.0 d2|Ter|0.8.8 highlight-matching-tag|vin|0.11.0 intellicode-api-usage-examples|Vis|0.2.8 vscodeintellicode|Vis|1.2.30 volar|Vue|1.8.22 change-case|wma|1.0.0 JavaScriptSnippets|xab|1.8.0 pretty-ts-errors|yoa|0.5.2 markdown-all-in-one|yzh|3.5.1 vitest-explorer|Zix|0.2.43 (1 theme extensions excluded)
lszomoru commented 12 months ago

/gifPlease

vscodenpa commented 12 months ago

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.

If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.

Happy coding!

vscodenpa commented 11 months ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

crystalfp commented 11 months ago

After machine reboot the problem does not happen anymore.

crystalfp commented 11 months ago

Today happened again. In line 46 I changed the value from true to false, but the working tree shows only the new value. Note that in the scrollbar both kind of line are show. image Version: 1.85.1 Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2 Date: 2023-12-13T09:49:37.021Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.85.1 Chrome/114.0.5735.289 Electron/25.9.7 Safari/537.36

crystalfp commented 11 months ago

The same happened at line 213 where I changed two lines into one. image The same also happened in other files of the same project.

Restarting VSC solved the issue.

lszomoru commented 10 months ago

/gifPlease

vscodenpa commented 10 months ago

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.

If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.

Happy coding!

crystalfp commented 10 months ago

Besides the screenshot I sent, no operation needs to be documented with a gif. The problem appears suddenly. Now VSC works as usual, so I cannot provide any more information.

lszomoru commented 10 months ago

@hediet, could you please take a look as this seems to be related to the diff editor? Thanks!

hediet commented 10 months ago

This should be fixed with https://github.com/microsoft/vscode/pull/201714

/duplicate https://github.com/microsoft/vscode/issues/198471