Cloud Changes causes data loss. Should notify before applying changes.

jasonswearingen commented 12 months ago

sorry not a real bug report, as I don't know how to repro, but a FYI.

the problem:

cloud changes caused dataloss because it restored stale data

the setup:

I have a single dev machine, have cloud-changes turned on in VSCode.
I do not open my repository on any other computer (but do use VSCode on another computer if that matters?)
I do 100% of my coding in VS (not VSCode), but use VSCode side-by-side to edit config files, etc.
IIRC I didn't have any .cs files open in VSCode. I did have the folder parent of the .sln open. I might have had another VSCode window with the .sln folder open also.

the steps?

had the above vscode windows open
make changes in VS (not vscode), commit to repo (using the "Fork" Git Client).
make some additional changes using VS as client.
reboot my computer (iirc, this will cause VSCode to store cloud changes)
open VS, see my (pending) changes
open a VSCode window (parent folder of .sln) and suddenly all my edits are blown away, files are in a state prior to last git commit.

additional thoughts

this might be considered a weird edge case and almost "by design", except:
when storing cloud changes, should track what the source was, and if source matches destination to overwrite, potentially something bad is about to happen
should prompt the user to restore cloud changes, preferably with a diff shown. (this is the big one)
sorry I don't have a nice way to repro this.
it left a super bad taste in my mouth so cloud changes is now off, forever.

joyceerhl commented 11 months ago

Sorry for the trouble and thanks for reporting.

prompt the user to restore cloud changes

This is strange. We notify if we detect that resuming changes would overwrite local changes. We also don't resume stale changes if they were generated for an unrelated commit (there is an experimental setting which will notify you if there are stored changes which have a different commit but same ref and repo). Can you share your settings just in case?

jasonswearingen commented 11 months ago

Here are my settings (from appData). I don't use per-folder/project settings. IIRC the last thing I did was disable the cloud changes. settings.json

If it matters, I tend to have many different VSCode windows open, for example: one for the git repo root, one for the .csproj root, and maybe another one-off editing some random file somewhere on the HD.

microsoft / vscode