search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.99k stars 28.25k forks source link

Tab title is covered when italic #200309

Open yiliang114 opened 7 months ago

yiliang114 commented 7 months ago

The editor is in a dirty state, font is italic, when workbench.editor.tabSizing is set to fixed or shrink, it will cause part to be covered.

image

Reproduction steps:

  1. open vscode.dev
  2. open welcome tab as example
  3. use cmd + , and search workbench.editor.tabSizing, toggle the configuration item and observe the editor title

Version: 1.84.2 Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36 Embedder: vscode.dev

benibenj commented 7 months ago

@yiliang114 This only happens for the "Welcome" view right? This doesn't happen for another tab which is italic? Then I know what is happening. It has to do with the icon we are using which is set in a different way then the other icons.

yiliang114 commented 6 months ago

@yiliang114 This only happens for the "Welcome" view right? This doesn't happen for another tab which is italic? Then I know what is happening. It has to do with the icon we are using which is set in a different way then the other icons.

Sorry too long no reply.

In fact, all editor tabs have this problem rather than the Welcome view. Such as

image image

Some fonts will be more obvious.

bpasero commented 3 months ago

See also: https://github.com/microsoft/vscode/issues/207409#issuecomment-2041842528

yiliang114 commented 3 months ago

See also: #207409 (comment) 另请参见: #207409 (comment)

I think I got what you meant. The best solution is to restore the overflow to fix this issue and use other methods to fix #200054. I'll try again.