search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.27k stars 29.31k forks source link

Align styling of toggled actions and toggled buttons #200810

Open bpasero opened 11 months ago

bpasero commented 11 months ago

We show a maximized editor group with a toggled icon:

image

Meanwhile we have an existing style for when something is toggled:

image

I think the latter is much more explicit and inviting to click, so I think we should align the former to it.

//cc @joaomoreno

gjsjohnmurray commented 11 months ago

My PR #198979 is slightly related to this UX topic.

benibenj commented 11 months ago

Aligning seems good, but personally, I think the second option stands out a bit too much for actions in for example the tab bar. I think these are actions that you don't press often. They should indicate to the user that something is active, but not be too inviting to press.

@hediet I think you introduced this toggled background for your diff setting icons. What are your thoughts on this?

bpasero commented 11 months ago

Just for comparison: XCode changes the icon when you maximize a group and they choose to show a prominent blue background color as well:

image