microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.42k stars 28.1k forks source link

Incorrect Keyboard Focus Order in "AIGC-Test Extension" Window: A11y_Visual Studio Code_AIGC Window_FocusOrder #201296

Closed ManishaC1 closed 5 months ago

ManishaC1 commented 6 months ago

[Check out Accessibility Insights!]- Identify accessibility bugs before check-in and make bug fixing faster and easier.

GitHubTags:

A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2023; #WCAG2.4.3; #FocusOrder; #AILimited; #WWL:Bug1643902; #A11yMAS;

Environment and OS details:

Version: 1.85.0-insider (user setup) Commit: b3a649fe52c0fb8692c9b28dfe25227c97521884 Date: 2023-11-15T09:43:13.091Z Electron: 25.9.4 ElectronBuildId: 25127168 Chromium: 114.0.5735.289 Node.js: 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.22621

Windows 11 22H2(OS Build 22621.2821)

Pre-requisites:

Here are the steps for using the AIGC extension in VS Code from scratch:

  1. Download and install the latest version of VS Code from the official website: https://code.visualstudio.com/download.
  1. Download and install Git from the official website: https://git-scm.com/downloads.
  1. Open VS Code by searching for it in the Windows start menu.

  2. Clone the repository from Azure DevOps .

  1. Install the AIGC extension for VS Code.
  1. Click on the AIGC extension icon in the left side of VS Code to open the AIGC window.
  1. Open a markdown file under the includes folder, select the entire text, right click, and select "AIGC: Generate Knowledge check".

Repro Steps:

  1. Launch Visual Studio
  2. Install AIGC-Test Extension.
  3. Tab within the AIGC-Test Extension section, check whether focus order is logical.

    Actual Result:

Keyboard Focus Order within "AIGC-Test Extension" window is not correct. When the focus is on the "Close" button and the enter key is pressed, the focus shifts to the "Status bar" located outside of the extension window. And with the next Tab key is pressed, the focus moves onto the prompt within the extension.

Expected Result:

Upon pressing the enter key while the focus is on the "Close" button, the keyboard focus should remain within the confines of the extension window. Close button-->Clear chat button-->Insert button-->Edit section

Attachment:

Visual Studio Code_Incorrect focus Order.zip

ManishaC1 commented 6 months ago

WWL Bug link-->https://dev.azure.com/worldwidelearning/WWL%20Accessibility/_workitems/edit/1643902

meganrogge commented 6 months ago

I am not sure what you mean. Can you please provide a gif?

VSCodeTriageBot commented 6 months ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

ManishaC1 commented 5 months ago

@meganrogge Please activate the bug.

I have attached a gif capturing incorrect focus order using NVDA screen reader. Without screen reader it would be hard to understand about the whereabouts of the focus order. Additionally, I've included another detailed video addressing the issue. Observed focus order: close button-->status bar present outside of chat window-->edit section present within chat section. Expected focus order: close button-->clear chat button-->Insert button-->edit section.

Presentation1

https://github.com/microsoft/vscode/assets/105198219/4cbc8898-75aa-4419-9aa0-6e5b0f09cda1

meganrogge commented 5 months ago

when I follow your repro steps, I get an error so cannot continue. Furthermore, this seems like a niche edge case. Could you pls provide repro steps that demonstrate a more general/ easier to hit issue? Thanks.

Also cc @isidorn in case i'm misunderstanding

Image

isidorn commented 5 months ago

Please file against the AIGC extension, this view is contributed by that extensions, and it is a custom web view. VS Code does not control this. Thank you