Closed ManishaC1 closed 5 months ago
I am not sure what you mean. Can you please provide a gif?
This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!
@meganrogge Please activate the bug.
I have attached a gif capturing incorrect focus order using NVDA screen reader. Without screen reader it would be hard to understand about the whereabouts of the focus order. Additionally, I've included another detailed video addressing the issue. Observed focus order: close button-->status bar present outside of chat window-->edit section present within chat section. Expected focus order: close button-->clear chat button-->Insert button-->edit section.
https://github.com/microsoft/vscode/assets/105198219/4cbc8898-75aa-4419-9aa0-6e5b0f09cda1
when I follow your repro steps, I get an error so cannot continue. Furthermore, this seems like a niche edge case. Could you pls provide repro steps that demonstrate a more general/ easier to hit issue? Thanks.
Also cc @isidorn in case i'm misunderstanding
Please file against the AIGC extension, this view is contributed by that extensions, and it is a custom web view. VS Code does not control this. Thank you
[Check out Accessibility Insights!]- Identify accessibility bugs before check-in and make bug fixing faster and easier.
GitHubTags:
A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2023; #WCAG2.4.3; #FocusOrder; #AILimited; #WWL:Bug1643902; #A11yMAS;
Environment and OS details:
Version: 1.85.0-insider (user setup) Commit: b3a649fe52c0fb8692c9b28dfe25227c97521884 Date: 2023-11-15T09:43:13.091Z Electron: 25.9.4 ElectronBuildId: 25127168 Chromium: 114.0.5735.289 Node.js: 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.22621
Windows 11 22H2(OS Build 22621.2821)
Pre-requisites:
Here are the steps for using the AIGC extension in VS Code from scratch:
Choose the right version to match your OS and select the standalone installer.
Once downloaded, double click the installer to install VS Code with default settings.
Open VS Code by searching for it in the Windows start menu.
Clone the repository from Azure DevOps .
Switch to Source Control, click on Clone repository, paste the Repo URL(https://microsoftdigitallearning.visualstudio.com/DefaultCollection/Courseware/_git/LP_Sample_Qijie-Test), choose a local folder to store the content, and wait for the cloning process to complete.
Click Open in New Window and select "Yes, I trust the authors" in the pop-up window.
Download the AIGC extension file ( AIGC-Test-0.0.46.vsix), select Extensions in VS Code, click three dots, select "Install from VSIX...", navigate to the extension file, select it, and click Install.
The AIGC-Test icon should appear in the Installed extension list.
In the AIGC window, verify the prompt is automatically selected as "Design knowledge check questions on", type a number in "Number of Questions", and click the Send icon.
Wait for the AIGC response with two knowledge check questions.
To insert the generated content to your file, put the cursor at the end of the content, click Insert in the AIGC window, and verify that the two questions are appended to the content.
Repro Steps:
Tab within the AIGC-Test Extension section, check whether focus order is logical.
Actual Result:
Keyboard Focus Order within "AIGC-Test Extension" window is not correct. When the focus is on the "Close" button and the enter key is pressed, the focus shifts to the "Status bar" located outside of the extension window. And with the next Tab key is pressed, the focus moves onto the prompt within the extension.
Expected Result:
Upon pressing the enter key while the focus is on the "Close" button, the keyboard focus should remain within the confines of the extension window. Close button-->Clear chat button-->Insert button-->Edit section
Attachment:
Visual Studio Code_Incorrect focus Order.zip