microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.65k stars 28.68k forks source link

Upstream forceallocationstov8sandbox feature of utility process #202385

Open deepak1556 opened 8 months ago

deepak1556 commented 8 months ago

Issue is starting point to reduce the patch set added for https://github.com/microsoft/vscode/issues/177338 in our internal builds and a way to get https://github.com/electron/electron/pull/37582 into OSS Electron.

1) Patch at chromium layer is about a way to initialize the configurable pool for the utility process. At the moment, the configurable pool is only meant to be used by V8 array buffer allocations. First step would be to create a discussion with upstream to see if there is interest in exposing the pool for embedder use case.

2) Second patch at chromium layer disables BRP feature for utility process since the configurable pool does not work with the feature. This can be also be solved as part of 1)

Once the above points are resolved we should be able to move the PR in Electron forward no patch overhead.

/cc @zcbenz

deepak1556 commented 8 months ago

Upstream issue for discussion https://bugs.chromium.org/p/v8/issues/detail?id=14585