search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
161.72k stars 28.43k forks source link

Aux window: do not render URL bar below title #202430

Open futurist opened 7 months ago

futurist commented 7 months ago

Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce:

  1. Chrome Browser, open vscode.dev
  2. Install PWA
  3. Open a file, right click in Tab Title Menu: Move into new Window
  4. The Opened floating window shown extra blank title area.

image

bpasero commented 7 months ago

This is something Chrome seems to be adding, when not using PWA you can see its this:

image

And it seems to be the same in PWA, even though not rendering the same:

image

If someone knows how to disable this, please chime in. It is possible though that for security reasons this cannot be changed.

jzyrobert commented 7 months ago

@bpasero I can't find the exact source for this, but for security reasons the url bar will always be shown unless the site has a valid SSL certificate. I can see that the popup window is opened with about:blank here: https://github.com/microsoft/vscode/blob/6d6bb5889a1eed4afb4d9bfec9cbda6720a189d9/src/vs/workbench/services/auxiliaryWindow/browser/auxiliaryWindowService.ts#L264

But I don't know how you would change that to be e.g. https://vscode.dev instead. auxiliaryWindow.history.replaceState may or may not work.

Goughy1991 commented 7 months ago

202684

[[_](url/)" 88x8v 2 ,,, xuc88x2p 6 6 alov R9 can X7 xxx K7 I 8 7l26 xxx qz@"6💎'ai art AXA AXA