microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.76k stars 29.1k forks source link

Can't dismiss inline chat using keyboard #204427

Closed omermizr closed 8 months ago

omermizr commented 8 months ago

Type: Bug

  1. Open inline chat (SHIFT + I)
  2. Try to close it using the keyboard

Expected: ESC or SHIFT + ESC closes the chat Actual: Only clicking the X with the mouse closes it

VS Code version: Code - Insiders 1.87.0-insider (Universal) (ec291c126878742ad640055ce604a58129cd088c, 2024-02-05T05:47:43.946Z) OS version: Darwin arm64 23.2.0 Modes:

System Info |Item|Value| |---|---| |CPUs|Apple M1 Max (10 x 24)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|10, 11, 12| |Memory (System)|32.00GB (0.06GB free)| |Process Argv|--crash-reporter-id 70a87a82-3a18-4efd-a579-683643eba8e8| |Screen Reader|no| |VM|0%|
Extensions (58) Extension|Author (truncated)|Version ---|---|--- better-comments|aar|3.0.2 TabOut|alb|0.2.2 Bookmarks|ale|13.4.2 scratchpads|bue|1.0.0 simple-react-snippets|bur|1.2.7 path-intellisense|chr|2.8.5 regex|chr|0.4.0 vscode-eslint|dba|2.4.4 es7-react-js-snippets|dsz|4.4.3 gitlens|eam|2024.2.404 prettier-vscode|esb|10.1.0 vscode-expo-tools|exp|1.0.7 vscode-jest-runner|fir|0.4.72 code-runner|for|0.12.1 shell-format|fox|7.2.5 copilot|Git|1.156.689 copilot-chat|Git|0.13.2024020201 remotehub|Git|0.63.2024010901 gitlab-workflow|Git|3.101.1 todo-tree|Gru|0.0.226 selected-lines-count|gur|1.4.0 debug-visualizer|hed|2.4.0 realtime-debugging|hed|0.1.0 vscode-power-mode|hoo|3.0.2 search-editor-apply-changes|jak|0.1.1 jwt-decoder|jfl|1.2.0 svg|joc|1.5.3 git-graph|mhu|1.30.0 vscode-docker|ms-|1.28.0 vscode-edge-devtools|ms-|2.1.4 jupyter|ms-|2024.2.2024020501 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.17 vscode-jupyter-cell-tags|ms-|0.1.8 vscode-jupyter-slideshow|ms-|0.1.5 remote-repositories|ms-|0.41.2023121801 vscode-js-profile-flame|ms-|1.0.8 vscode-typescript-next|ms-|5.4.20240204 vscode-react-native|msj|1.12.3 color-highlight|nau|2.5.0 vscode-twoslash-queries|Ort|1.2.2 vscode-versionlens|pfl|1.9.2 quicktype|qui|12.0.46 vscode-xml|red|0.26.1 vscode-yaml|red|1.14.0 partial-diff|ryu|1.4.3 vscode-javascript-booster|sbu|14.0.1 vscode-fileutils|sle|3.10.3 code-spell-checker|str|3.0.1 even-better-toml|tam|0.19.2 luna-paint|Tyr|0.16.0 errorlens|use|3.16.0 intellicode-api-usage-examples|Vis|0.2.8 quokka-vscode|Wal|1.0.625 vscode-import-cost|wix|3.3.0 vscode-jumpy|wma|0.3.1 pretty-ts-errors|Yoa|0.5.3 markdown-all-in-one|yzh|3.6.2
A/B Experiments ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscod805:30301674 vsaa593:30376534 py29gd2263:30784851 c4g48928:30535728 a9j8j154:30646983 962ge761:30841072 pythongtdpath:30726887 welcomedialog:30812478 pythonidxpt:30768918 pythonnoceb:30776497 asynctok:30898717 dsvsc013:30777762 dsvsc014:30777825 dsvsc015:30821418 pythontestfixt:30866404 pythonregdiag2:30926734 pyreplss1:30879911 pythonmypyd1:30859725 pythoncet0:30859736 pythontbext0:30879054 accentitlementst:30870582 dsvsc016:30879898 dsvsc017:30880771 dsvsc018:30880772 d34g3935:30953408 b5d27386:30943795 fegfb526:30952798 7j2b6412:30951517 bg6jg535:30946824 ccp2r3:30950906 ```
omermizr commented 8 months ago

This is a dupe of https://github.com/microsoft/vscode/issues/204426 Can close Thanks @jrieken