search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.87k stars 29.15k forks source link

Inno setup - automatically install language pack #205666

Open lszomoru opened 8 months ago

lszomoru commented 8 months ago

Testing #205564

I might misunderstand the scope of the work here but I would have expected that if I go through the setup using a particular language, when the product launches it would make the language of the setup. I think that it would be nice to automatically install the language pack that matches the setup language.

benibenj commented 8 months ago

This is not very related to the scope of this work, however, this is still a valid feature request and I wondered the same thing after running the setup scripts in the different languages. Maybe @joaomoreno or @TylerLeonhardt can clarify why we aren't doing so yet.

TylerLeonhardt commented 8 months ago

Might be a cool thing to explicitly call out in the setup. Streamline things.

Today, after they install VS Code and they open it for the first time, you do get a notification that says "do you wanna get the language pack" in the language that their OS is set to (if we have a language pack for that language of course)

So we do kinda have a solution for this, but it's not as nice as a checkbox in the setup.

I don't have history to understand why we didn't do this before. Maybe the solution was good enough, but I think we should consider it if it's relatively straightforward.