search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.14k stars 29.28k forks source link

Setting editor.find.seedSearchStringFromSelection to Selection still seed the Find Widget from not selected words #205946

Open teoincontatto opened 8 months ago

teoincontatto commented 8 months ago

Does this issue occur when all extensions are disabled?: Yes

Version: 1.86.1
Commit: 31c37ee8f63491495ac49e43b8544550fbae4533
Date: 2024-02-07T09:07:19.849Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Linux x64 5.15.0-94-generic snap

Steps to Reproduce:

  1. Set editor.find.seedSearchStringFromSelection to selection
  2. Open a text file and selecting a text (cursorColumnSelectLeft/cursorColumnSelectRight, usually shift+left/shift+right arrow key)
  3. Find Next Selection (editor.action.nextSelectionMatchFindAction key) -> Will feed the Find Widget with the selected word
  4. Move the cursor to any other different word in the text without selecting it -> The word is highlightened
  5. Find Next Selection (editor.action.nextSelectionMatchFindAction key) -> Will feed the Find Widget with the other highlightened word

At this point the other different word is searched instead of the one that was searched in step 3

Reproducible also if editor.find.seedSearchStringFromSelection is set to never in step 1

See also https://github.com/microsoft/vscode/issues/20768#issuecomment-1146015487

vscodenpa commented 8 months ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

teoincontatto commented 8 months ago

Checked on latest VS Code Version, bug is still present:

Version: 1.86.2
Commit: 903b1e9d8990623e3d7da1df3d33db3e42d80eda
Date: 2024-02-13T19:41:37.860Z
Electron: 27.2.3
ElectronBuildId: 26908389
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Linux x64 5.15.0-94-generic snap
teoincontatto commented 2 months ago

@rebornix Sorry to bother, but this seems to have been forgotten. Would you mind have a look at this?