Terminal line height cutting off the bottom of characters with Nerd Fonts

Type: Bug

When entering commands in a terminal and at the bottom of the view (so, previous commands have been entered such that the next command is as far down the window as possible) characters that dip below the natural line (like ygpq) have their bottoms cut off.

This began happening within the last release or two when there were some changes made to terminal rendering (I believe, from memory).

The font I'm using is SauceCodePro NF. When I switch to a non-NF, the characters are no longer cut off. If I switch the line height to 1.2 the text is no longer cut off, but the look is a bit 🤮

Terminal settings:

  "terminal.integrated.shellIntegration.enabled": false,
  "terminal.integrated.fontSize": 14,
  "terminal.integrated.fontFamily": "SauceCodePro NF",
  "terminal.integrated.scrollback": 10000,
  "terminal.external.osxExec": "iTerm.app",
  "terminal.integrated.tabs.showActiveTerminal": "always",
  "terminal.integrated.tabs.focusMode": "singleClick",
  "terminal.integrated.defaultProfile.osx": "zsh",

nerd-font

non-nerd-font

VS Code version: Code 1.86.2 (903b1e9d8990623e3d7da1df3d33db3e42d80eda, 2024-02-13T19:42:12.210Z) OS version: Darwin arm64 23.3.0 Modes:

System Info

|Item|Value| |---|---| |CPUs|Apple M2 (8 x 24)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|3, 3, 3| |Memory (System)|24.00GB (5.40GB free)| |Process Argv|--crash-reporter-id 97addac9-f01a-4553-b901-fffadef6f51e| |Screen Reader|no| |VM|0%|

Extensions: none

A/B Experiments

``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscoreces:30445986 vscod805:30301674 binariesv615:30325510 vsaa593cf:30376535 py29gd2263:30899288 vscaat:30438848 c4g48928:30535728 azure-dev_surveyone:30548225 vscrp:30673768 962ge761:30959799 pythongtdpath:30769146 welcomedialogc:30910334 pythonidxpt:30866567 pythonnoceb:30805159 asynctok:30898717 pythontestfixt:30902429 pythonregdiag2:30936856 pyreplss1:30897532 pythonmypyd1:30879173 pythoncet0:30885854 pythontbext0:30879054 accentitlementsc:30887149 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 pydisww1:30959800 d34g3935:30971562 edj9j583:30969295 fegfb526:30961430 7j2b6412:30969109 bg6jg535:30958357 ```

microsoft / vscode

Terminal line height cutting off the bottom of characters with Nerd Fonts #206324