microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.6k stars 29.03k forks source link

Can't disable "An external application wants to open" warnings #207777

Closed dgattey closed 5 months ago

dgattey commented 7 months ago

Type: Bug

I can't disable the "an external application wants to open this file" warnings ("Prompt for local file protocol handling" in settings). I have the checkboxes off in my Settings, and every time I see the warning I check the box to say "allow opening local paths without warnings", yet the warning won't stop. Here's a loom showing the problem in full detail:

https://www.loom.com/share/02d73ee168de4c018ea09c07c2920cc2?sid=6ad60f4a-23b5-4592-b2ca-b6f0288870b2

VS Code version: Code 1.87.1 (Universal) (1e790d77f81672c49be070e04474901747115651, 2024-03-06T00:23:16.418Z) OS version: Darwin arm64 23.4.0 Modes:

System Info |Item|Value| |---|---| |CPUs|Apple M3 Pro (11 x 24)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|2, 3, 3| |Memory (System)|36.00GB (0.24GB free)| |Process Argv|--crash-reporter-id c845d03f-9197-44fd-85e2-84c62baf5260| |Screen Reader|no| |VM|0%|
Extensions (54) Extension|Author (truncated)|Version ---|---|--- op-vscode|1Pa|1.0.4 bundle-size|amb|1.7.0 vscode-color|ans|0.4.5 graphql-codegen-vscode|cap|1.1.1 multi-cursor-case-preserve|Car|1.0.5 npm-intellisense|chr|1.4.5 postcss|css|1.0.9 vscode-eslint|dba|2.4.4 parquet-viewer|dvi|2.7.0 gitlens|eam|14.9.0 prettier-vscode|esb|10.1.0 file-icons|fil|1.1.0 auto-rename-tag|for|0.1.10 codespaces|Git|1.16.13 copilot|Git|1.172.0 copilot-chat|Git|0.13.1 vscode-github-actions|git|0.26.2 vscode-pull-request-github|Git|0.82.0 vscode-graphql|Gra|0.9.3 vscode-graphql-syntax|Gra|1.3.4 closeunmodified|Gru|0.0.7 todo-tree|Gru|0.0.226 vscode-test-explorer|hbe|2.21.1 vscode-edit-csv|jan|0.9.1 vs-docblock|jer|1.4.0 remove-unused-imports|kus|1.2.3 vscode-python-test-adapter|lit|0.8.2 vscode-json5|mrm|1.0.0 playwright|ms-|1.0.22 black-formatter|ms-|2024.0.1 debugpy|ms-|2024.2.0 flake8|ms-|2023.10.0 isort|ms-|2023.10.1 mypy-type-checker|ms-|2023.6.0 python|ms-|2024.2.1 vscode-pylance|ms-|2024.3.1 live-server|ms-|0.4.13 test-adapter-converter|ms-|0.1.9 vsliveshare|ms-|1.0.5918 autodocstring|njp|0.6.1 material-icon-theme|PKi|4.34.0 tsimporter|pmn|2.0.1 postman-for-vscode|Pos|0.19.1 vscode-yaml|red|1.14.0 markdown-preview-enhanced|shd|0.8.12 indenticator|Sir|0.7.0 vscode-fileutils|sle|3.10.3 vscode-graphql|stp|0.3.0 ayu|tea|1.0.5 vscode-mdx|uni|1.8.1 vscodeintellicode|Vis|1.3.0 vscode-icons|vsc|12.7.0 change-case|wma|1.0.0 zoombar-vscode|wra|1.4.4 (2 theme extensions excluded)
A/B Experiments ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492cf:30256860 vscorecescf:30445987 vscod805:30301674 binariesv615:30325510 vsaa593cf:30376535 py29gd2263:30899288 c4g48928:30535728 azure-dev_surveyone:30548225 2i9eh265:30646982 962ge761:30959799 pythongtdpath:30769146 welcomedialog:30910333 pythonidxpt:30866567 pythonnoceb:30805159 asynctok:30898717 pythontestfixt:30902429 pythonregdiag2:30936856 pyreplss1:30897532 pythonmypyd1:30879173 pythoncet0:30885854 2e7ec940:30986170 pythontbext0:30879054 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfcontrol:30979541 d34g3935:30971562 fegfb526:30981948 bg6jg535:30979843 dsvsc020:30976470 ```
vscodenpa commented 7 months ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

dgattey commented 7 months ago

I just upgraded to 1.87.2 and tried again! Issue still remains 😒

bpasero commented 7 months ago

@dgattey can you open the settings editor as JSON file (from the editor tool bar) and give me the exact values for security.promptForLocalFileProtocolHandling and security.promptForRemoteFileProtocolHandling

Also, I assume you are not connected to a remote and this is all local?

vscodenpa commented 6 months ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

dgattey commented 6 months ago

Oops @bpasero missed the reply sorry. Both of those are set to false. I'm not connected to remote, this is all local.

"security.promptForRemoteFileProtocolHandling": false,
"security.promptForLocalFileProtocolHandling": false,
dgattey commented 6 months ago

Should I open a new issue or can this be reopened @bpasero? Still encountering this problem! I added a bit more color here: https://github.com/microsoft/vscode/issues/198336#issuecomment-2035845649. Maybe it's related to ~ resolution for the home folder on macOS?

bpasero commented 6 months ago

@dgattey two more ideas:

vscodenpa commented 6 months ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

tjx666 commented 6 months ago

@bpasero

I can still occurs this issue in latest stable release when using: https://github.com/lmichelin/open-github-links-in-ide

image

Version:

Version: 1.88.1 (Universal)
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:42:52.765Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 23.4.0
bpasero commented 6 months ago

@tjx666 thanks so much for the screenshot, it pointed me to the right direction! this setting cannot be configured on a per-profile level but only globally because it is read from a context that is not profile aware πŸš€

I will have a fix ready, but this explains everything. @dgattey are you also using profiles?

To fix this for now:

dgattey commented 6 months ago

@tjx666 thanks so much for the screenshot, it pointed me to the right direction! this setting cannot be configured on a per-profile level but only globally because it is read from a context that is not profile aware πŸš€

I will have a fix ready, but this explains everything. @dgattey are you also using profiles?

To fix this for now:

  • go back to the default profile

  • configure the setting

Yup, I'm using a profile. Glad to hear! I'll try swapping the setting in the default profile

lramos15 commented 6 months ago

@bpasero How does one trigger this dialog?

bpasero commented 6 months ago

Yeah by pasting one of these vscode links into the browser: https://stackoverflow.com/questions/48641921/is-it-possible-to-use-the-vscode-hyperlink-to-open-a-file-or-directory-in-code

You would need to use vscode-insider as scheme. It should then bring up a dialog asking for confirmation and when you click the do not show again button write a setting into the global scope (not the profile).

vscodenpa commented 6 months ago

This bug has been fixed in the latest release of VS Code Insiders!

@dgattey, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 6d23b7f11a3d7292b9458f0de7160048089398f9 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

lramos15 commented 5 months ago

@bpasero When I check the box and go back to the link and try again I get the modal again

image

Here's the URI link I'm using vscode-insider://file/users/lramos15/upstream/vscode/.vscode/notebooks/endgame.github-issues

It opens the endgame notebook without issue

bpasero commented 5 months ago

This is an expensive bug :D