[Bug] Can't search chats in quick open

[wenfangdu]

I have a chat open: But it can't be found after typing the keywords:

[tcostew]

Can I be assigned to this?

[wenfangdu]

@tcostew Thanks for dropping by, you can start a PR without being assigned.

[bpasero]

This is intentional, though arguable not very intuitive, if you want to strictly search through editors, there are pickers that only list editors.

[wenfangdu]

@bpasero Why intentional? With multiple chats open and tons of editors mixed in, it's very hard to pick the wanted chat.

[bpasero]

The standard file picker shows recently opened editors at the top when you do not search. This is already a bit inconsistent in that we include non-file editors here as well (for example chats or terminals). That is historic because we wanted to allow a user to quickly open a previous editor without searching. But the intent of the picker is to provide file search once you start typing, as you can see from the description:

As such, we exclude results from the list that are not file based (such as chat, terminal).

The edt <search> picker is meant for searching through all opened editors:

[wenfangdu]

@bpasero Thanks for the history recap, but I think if you remove the constraints i.e. terminal and chat editors can be searched through typing, it does no harm, right? Since it's an extension not a regression.

[bpasero]

Yeah, I think I am not opposed to changing this but then we should include everything from recently opened and drop the check for files.

[wenfangdu]

@bpasero Yes, please do so, is there an estimated date for this change? search.exclude should still apply though.