search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.1k stars 28.82k forks source link

Blank settings editor when offline #209334

Open Dominicus1165 opened 6 months ago

Dominicus1165 commented 6 months ago

Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.86 / 1.87 OS Version: W10 22H2 Steps to Reproduce:

Install in offline environment

I have the exact same problems as in #195722. The settings load after around 1-2 minutes. When connecting via remoteSSH addon from offline PC to offline server, the settings never load.

Developer Tools show error in console

It takes around 60s for the settings to appear. The exact moment they appear, an error appears in Console of dev tools. It looks like it waits for a timeout to occur.

Failed to load ressource: net::ERR_NAME_NOT_RESOLVED (in https://marketplace.visualstudio.com/_apis/public/gallery/extensionsquery)
Failed to load ressource: net::ERR_NAME_NOT_RESOLVED (in https://marketplace.visualstudio.com/_apis/public/gallery/extensionsquery)
POST https://marketplace.visualstudio.com/_apis/public/gallery/extensionsquery net::ERR_NAME_NOT_RESOLVED (in workbench.desktop.main.jg:95)
POST https://marketplace.visualstudio.com/_apis/public/gallery/extensionsquery net::ERR_NAME_NOT_RESOLVED (in workbench.desktop.main.jg:95)
Failed to load ressource: net::ERR_NAME_NOT_RESOLVED (in default.exp-tas.com/vscode/ab:1)
VSCodeTriageBot commented 6 months ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

rzhao271 commented 6 months ago

I'm unable to reproduce the issue. Which Windows setup are you using, e.g. System, User, Portable?

Dominicus1165 commented 6 months ago

It does not matter. Testes all variants. Fresh install on an offline machine. Tested on multiple machines. All had the same issue. All tried to connect to the marketplace.

Also lots of XHR failed errors. Can't look at them now though.

rzhao271 commented 6 months ago

I confirmed on Windows 11 on the latest Insiders with a fresh user-data-dir and extensions dir (which imitates a fresh install) that opening the Settings editor results in a request sent to the extensions gallery, but the exception gets caught right away for me and the settings load in instantly. I also only saw one exception error message when opening the Settings editor, and did not see several like in #195722.

rzhao271 commented 3 months ago

Hi @Dominicus1165, is the issue still occurring for you on VS Code 1.90?

Dominicus1165 commented 3 months ago

I will need to check in a few weeks. After lots of testing all versions after 1.82.x - 1.87.x are broken.

1.81.1 is the latest version that worked. Haven't tried newer versions yet. Will need to test this soon.

rzhao271 commented 2 hours ago

Hi @Dominicus1165, I merged in https://github.com/microsoft/vscode/pull/229738 a week ago and I believe it fixes some remaining networking issues within the Settings editor. Could you confirm with VS Code 1.94 whether the issue has been fixed for you?