microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.95k stars 29.53k forks source link

Disassembly window cannot be themed. #209369

Open Yazwh0 opened 8 months ago

Yazwh0 commented 8 months ago

Type: Feature Request

Currently the disassembly window cannot be themed, so it just uses while text.

It would be good to be able to theme this window, preferably via a assembly language so it can vary by the target processor.

VS Code version: Code 1.87.2 (863d2581ecda6849923a2118d93a088b0745d9d6, 2024-03-08T15:20:17.278Z) OS version: Windows_NT x64 10.0.22631 Modes:

IllusionMH commented 8 months ago

Where does this Window comes from? Is it provided by VS Code or an extension?

Most likely request should be in extension's repo.

Yazwh0 commented 8 months ago

VSCode. See here: https://devblogs.microsoft.com/cppblog/visual-studio-code-c-july-2021-update-disassembly-view-macro-expansion-and-windows-arm64-debugging/

Edit: Ok, so disassembly DAP support is via the cpp vscode extension, which is enabled by default across all projects?

Via DAP ( https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disassemble )

IllusionMH commented 8 months ago

I stand corrected. I thought it's custom WebView (e.g. Hex Editor), but it's separate built-in view https://github.com/microsoft/vscode/pull/125737

So looks like correct place to start.

roblourens commented 7 months ago

It does use the general workbench foreground color, which you can customize with foreground. But more customization may be good too

vscodenpa commented 7 months ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

vscodenpa commented 7 months ago

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

Yazwh0 commented 7 months ago

An example of how much better it could look:

image