code serve web --server-base-path PWA app does not include base path

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

163.16k stars 28.83k forks source link

code serve web --server-base-path PWA app does not include base path #209601

Open sasaandonov opened 6 months ago

sasaandonov commented 6 months ago

When we run vscode as code serve-web with the new option server-base-path, then PWA app doesn't work properly because it doesn't use the path(tested in chrome and edge).

sasaandonov commented 6 months ago

I suppose that you need to include base path in resources/server/manifest.json for option 'start_url'.

dbaeumer commented 5 months ago

@joaomoreno not sure if you are the right owner :-)

sasaandonov commented 3 months ago

ping