microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.74k stars 29.1k forks source link

Test: Experimental VS Code-native PowerShell intellisense #210394

Closed Tyriar closed 6 months ago

Tyriar commented 6 months ago

Refs: #154662

Complexity: 3

Create Issue


Some more work has been happening on PowerShell intellisense and we want to get some more eyes/testing on it. Please do a little exploratory testing in the terminal with the setting on, mostly using the terminal as you would normally do and report issues for when it didn't work as expected or was annoying.

Setup:

Set "terminal.integrated.shellIntegration.suggestEnabled": true and create a new pwsh (6+) terminal. See https://learn.microsoft.com/en-us/powershell/scripting/install/installing-powershell?view=powershell-7.4 for how to install the latest.

Usage:

Intellisense should show up based on the current prompt when you press ctrl+space:

image

It should show up automatically when you type the - character:

image image

cpendery commented 6 months ago

I think after some of the most recent changes, the suggestions just disappear on first input.

https://github.com/microsoft/vscode/assets/35637443/8d3b770c-e655-47f4-a7dd-55f234256205

Tyriar commented 6 months ago

@cpendery this is what I was seeing on macOS before. I made a change to fix it and it seems to have regressed again ๐Ÿค”

Tyriar commented 6 months ago

@cpendery looking into it https://github.com/microsoft/vscode/issues/210562

amunger commented 6 months ago

the font is off for me image

Tyriar commented 6 months ago

@amunger could you make an issue with your settings? I haven't seen that happen in a long time

abhijit-chikane commented 6 months ago

the font is off for me image

Same for me But is there a way we donโ€™t have to press the ctrl+space and should show up suggestions as we type just like how it shows up in editor

anyways this is really cool Nice work๐Ÿ‘

Tyriar commented 6 months ago

@abhijit-chikane it's meant to show when you type -, something is wrong if that's now happening

abhijit-chikane commented 6 months ago

@abhijit-chikane it's meant to show when you type -, something is wrong if that's now happening

Well i was talking about the font is off for me as well It does shows up when I press ctrl+space But I was saying it would be much better if we could show the suggestions as we type just like editor And one thing I have notice that the suggestions shows only for first word

Tyriar commented 6 months ago

@abhijit-chikane thanks for the feedback, maybe we can improve that ๐Ÿ‘

Tyriar commented 6 months ago

Had to take myself off testing macOS unfortunately as my macbook is getting repaired.

joaomoreno commented 6 months ago

This is soooo cool ๐Ÿ‘

TylerLeonhardt commented 6 months ago

Blocked until: https://github.com/microsoft/vscode/issues/211132 @Tyriar is aware of the fix required. Will shift focus to other TPIs while that gets released

abhijit-chikane commented 5 months ago

This should work like this Link to the full blog