search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
161.92k stars 28.46k forks source link

wrong font for terminal completions #210597

Closed amunger closed 1 month ago

amunger commented 4 months ago

testing https://github.com/microsoft/vscode/issues/210394#issue-2243874564

I see this on multiple machines, and when using an empty temporary profile where this is the only setting in settings.json

image

Tyriar commented 4 months ago

Can't repro by just commenting out settings, maybe my installed fonts being different is the issue.

Tyriar commented 4 months ago

Another report on macOS: https://github.com/microsoft/vscode/issues/211075

JustinGrote commented 2 months ago

Happened to me on Windows using 1.90 stable

image

starball5 commented 2 months ago

I'm seeing questions on SO about other font issues and I'm not sure if they're related to this or a separate issue.

Should I tell those people to raise a new issue ticket?

pa-0 commented 2 months ago

+1

sbatten commented 1 month ago

Same for me when testing https://github.com/microsoft/vscode/issues/223130

Tyriar commented 1 month ago

Well that's obvious:

https://github.com/microsoft/vscode/blob/12f9169c935bd3fd2730777130330c3bb19e0005/src/vs/workbench/services/suggest/browser/simpleSuggestWidgetRenderer.ts#L83-L94