microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.51k stars 28.1k forks source link

Diffs from ChatResponseTextEditParts should be inline when narrow #210793

Open connor4312 opened 2 months ago

connor4312 commented 2 months ago

Adopting the ChatResponseTextEditPart, it's very nice that it's shown in the diff editor, but it's a bit hard to read due to is narrowness

image

hediet commented 2 months ago

Seems to be intentially disabled:

https://github.com/microsoft/vscode/blob/a49c81edea6647684eee87d204e50feed9c455f6/src/vs/workbench/contrib/chat/browser/codeBlockPart.ts#L608

jrieken commented 2 months ago

It will almost always be narrow because chat is in the sidebar or inside an editor. We have discussed

@hediet Is the latter something the diff editor could support?

hediet commented 2 months ago

some smarts that automatically uses inline when diffs are dominated by insertions and/or removals

Yes, the diff editor could support this! I don't think this feature would work very well for changing/writable files, as it might jump.

jrieken commented 2 months ago

I don't think this feature would work very well for changing/writable files, as it might jump.

You could do this only on first open/load of a model but not on subsequent changes to the models.