Error rendering should be unified across notebooks and editor

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

164.33k stars 29.31k forks source link

Error rendering should be unified across notebooks and editor #211068

Open isidorn opened 6 months ago

isidorn commented 6 months ago

Testing #210942

I am not sure if the direction of rendering errors in a custom way in Notebooks is the best way forward. Could we somehow re-use our rendering in the problems view? Or nudge the users towards the Problems view? Do we want to build two problem rendering solutions?

fyi @lszomoru @joaomoreno

amunger commented 6 months ago

There is no problems matcher involved here, this is just the error output from the kernel process. Every kernel type can have it's own format, and they are very different between languages. If that still sounds like problem matchers would be a good fit, I'd definitely be interested in digging into that more, but I don't see them working here.