search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.99k stars 28.78k forks source link

Move viewModel utilities into `testNotebookEditor.ts` #211995

Open Yoyokrazy opened 5 months ago

Yoyokrazy commented 5 months ago

we could consider moving these utilities into testNotebookEditor

_Originally posted by @rebornix in https://github.com/microsoft/vscode/pull/211861#discussion_r1589784600_

https://github.com/microsoft/vscode/blob/aed4230a894876b1c5926be4c6f6830f7af25d76/src/vs/workbench/contrib/notebook/test/browser/contrib/notebookOutlineViewProviders.test.ts#L57-L100

Yoyokrazy commented 5 months ago

additionally, change source parameter to take in string[]. leaves us with an accurate way to call getLineCount

https://github.com/microsoft/vscode/blob/aed4230a894876b1c5926be4c6f6830f7af25d76/src/vs/workbench/contrib/notebook/test/browser/contrib/notebookOutlineViewProviders.test.ts#L57-L60