search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
158.92k stars 27.79k forks source link

Tasks run task and Configure task commands infinte load or no-op on vscode web #212047

Closed mahmoudsalah1993 closed 1 week ago

mahmoudsalah1993 commented 1 week ago

Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce:

  1. Open a repository on github, and hit . to open vscode.dev
  2. Open command palette and run Tasks: Run Task or Tasks: Configure Tasks

Expected:

Both commands show list of tasks pertraining to the repository or the option to create tasks.json etc

Actual:

Run tasks command simply is no-op not showing the quickpick. Configure task keeps infintely loading.

image

meganrogge commented 1 week ago

thanks for the issue, do you know if this happened in earlier versions of vscode.dev?

meganrogge commented 1 week ago

I see 

Warning: npm tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

in the output channel. Unsure if these worked before

mahmoudsalah1993 commented 1 week ago

We've had this issue reported for several months in our internal version of web-based vscode. The issue seemed to stem that both commands awaited for the onDidRegisterAllSupportedExecutions event to be fired, which in a web environment this never gets fired, shell executions aren't supported for example.

Changing the condition to fire if any execution type is registered https://github.com/microsoft/vscode/pull/212163 seems to resolve the issue and no issues seem to be visible user flow wise. The warnings generally show only when some non-supported executions are available, but don't cause issues for the dialog or show up as options for users.