microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.71k stars 28.15k forks source link

Missing Hot Reload button in debug toolbar #212143

Open iqfareez opened 2 months ago

iqfareez commented 2 months ago

Does this issue occur when all extensions are disabled?: Yes/No

Steps to Reproduce:

This issue coming from https://github.com/Dart-Code/Dart-Code/issues/5055. Cc @DanTup

  1. Install Flutter extension from marketplace
  2. Open/Create Flutter project in Vscode
  3. Run the app by clicking the run button inside the IDE
  4. Wait until the app is running on platform (eg emulators)

    Expected behavior

Hot reload button will appear :zap:

Screenshot 2024-05-07 at 12 09 20 PM

Actual behavior

Hot reload button doesn't appear

Screenshot 2024-05-07 at 12 06 06 PM

Workaround

Toggle debug.toolBarLocation brings back the Hot Reload Button

https://github.com/microsoft/vscode/assets/60868965/dbdf3ac5-60d1-45ae-8c55-4f08f07a225f

roblourens commented 1 month ago

Hey @DanTup, are you able to repro this? I set up a test extension that contributes a command the same way that the Dart extension does, and it works fine for me. I can try in the Dart extension too, but I'm wondering whether it's a fluke for this user or something that happens regularly.

roblourens commented 1 month ago

Ah nevermind, I guess I do have a repro using js-debug

roblourens commented 1 month ago

Hey @jrieken, I can't figure out how this is supposed to work in the command center. It seems that we don't listen to updates of the debug submenu inside the command center. Easy repro steps

jrieken commented 1 month ago

Weird, we should receive events and redraw the menu because of the emitEventsForSubmenuChanges-flag.