search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.57k stars 28.66k forks source link

workbench.colorTheme not working anymore #212346

Closed imbroisi closed 4 months ago

imbroisi commented 4 months ago

Type: Bug

Installing the new VSCode version the workbench.colorTheme configuration is not working anymore. I reverted to the previous version (1.88.1) and it worked again.

Version: 1.89.0 (Universal) Commit: b58957e67ee1e712cebf466b995adf4c5307b2bd Date: 2024-05-01T02:10:10.196Z Electron: 28.2.8 ElectronBuildId: 27744544 Chromium: 120.0.6099.291 Node.js: 18.18.2 V8: 12.0.267.19-electron.0 OS: Darwin arm64 23.4.0

VS Code version: Code 1.89.0 (Universal) (b58957e67ee1e712cebf466b995adf4c5307b2bd, 2024-05-01T02:10:10.196Z) OS version: Darwin arm64 23.4.0 Modes:

System Info |Item|Value| |---|---| |CPUs|Apple M1 (8 x 24)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|3, 2, 3| |Memory (System)|16.00GB (0.08GB free)| |Process Argv|. --crash-reporter-id 1a776cc5-b128-4597-81b9-438a3544869f| |Screen Reader|no| |VM|0%|
Extensions (18) Extension|Author (truncated)|Version ---|---|--- vscode-custom-css|be5|7.2.1 vscode-tailwindcss|bra|0.10.5 simple-react-snippets|bur|1.2.8 gitlens|eam|2024.5.905 todo-tree|Gru|0.0.226 vscode-react-typescript|inf|1.3.1 rainbow-csv|mec|3.11.0 vscode-docker|ms-|1.29.1 vscode-language-pack-pt-BR|MS-|1.89.2024050109 vsliveshare|ms-|1.0.5918 material-icon-theme|PKi|5.1.0 vscode-yaml|red|1.14.0 vscode-scss-formatter|sib|3.0.0 cody-ai|sou|1.16.5 autoimport|ste|1.5.4 vscode-styled-components|sty|1.7.8 vscode-todo-highlight|way|1.0.5 JavaScriptSnippets|xab|1.8.0 (2 theme extensions excluded)
A/B Experiments ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vstes627:30244334 vscorecescf:30445987 vscod805:30301674 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 c4g48928:30535728 azure-dev_surveyone:30548225 962ge761:30959799 pythongtdpath:30769146 welcomedialogc:30910334 pythonidxpt:30866567 pythonnoceb:30805159 asynctok:30898717 pythontestfixt:30902429 pythonregdiag2:30936856 pyreplss1:30897532 pythonmypyd1:30879173 pythoncet0:30885854 h48ei257:31000450 pythontbext0:30879054 accentitlementsc:30995553 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 jchc7451:30973076 dsvsc021:30996838 945dj816:31013170 fchga941:31038042 dwnewjupyter:31039675 ```
aeschli commented 4 months ago

There was a change: https://code.visualstudio.com/updates/v1_89#_auto-detect-system-color-mode-improvements

When window.autoDetectColorScheme is set, , the current theme is defined by the workbench.preferredDarkColorTheme setting when in dark mode, and the workbench.preferredLightColorTheme setting when in light mode.

In that case, the workbench.colorTheme setting is then no longer considered. It is only used when window.autoDetectColorScheme is off.