microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.23k stars 28.55k forks source link

Viewing sibling folders via breadcrumb select can show the wrong folder names #212363

Open isc-bsaviano opened 4 months ago

isc-bsaviano commented 4 months ago

When using a multi-root workspace that has folders whose URIs differ only in query parameters, the sibling folders shown via breadcrumb select have the wrong names. When expanded, the folder contents are correct. Consider the following workspace:

{
    "folders": [
        {
            "name": "abc",
            "uri": "isfs://iris:user/"
        },
        {
            "name": "def",
            "uri": "isfs://iris:user/?csp"
        }
    ]
}

Expected behavior:

Screenshot 2024-05-09 at 12 31 16 PM

Actual behavior:

Screenshot 2024-05-09 at 12 30 51 PM

See https://github.com/intersystems-community/vscode-objectscript/issues/1358

isc-bsaviano commented 2 months ago

Hi @jrieken, can you please review John's PR? It would be great to have this fixed in the same version as a related issue that was already fixed (#214329).