search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.22k stars 29.29k forks source link

Github Copilot advertisement causes delay in showing Settings UI #212375

Closed ghost closed 1 month ago

ghost commented 6 months ago

Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce:

  1. Open VS Code.
  2. Toggle Developer Tools and watch Network requests.
  3. In VS Code, open Settings.
  4. Observe that Settings will not display any settings until the requests to https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery are completed.
  5. Upon reading the results of the queries, observe that this request is related to the absolutely despicable advertisement for GitHub Copilot, to detect if it's already installed (or something) in order to show the ad in the Settings UI and that you are now even more incensed that something which should work immediately was taking 7 seconds or longer due to the fact that we are now living through a dystopia. Then quickly get over it and start considering a move to a different editor or a fork.

Please choose one of the following suggestions:

  1. Simply remove the GitHub Copilot advertisement from the Settings UI.
  2. Stop waiting for network requests in order to show the Settings UI.
  3. Close this issue and ignore this unquestionably sane plea to help battle the enfecalization of this beloved product.
vscodenpa commented 6 months ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

ghost commented 6 months ago

The AUR hasn't been updated with 1.89.1 yet but looking at the resolved issues I don't see any related to this.

rzhao271 commented 1 month ago

I have added a 1-second timeout per network request. In other words, the delays should now have an upper limit on their duration.