microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.76k stars 29.47k forks source link

Confusion with input tag in basicMarkupHtmlTags #213088

Open roblourens opened 6 months ago

roblourens commented 6 months ago

This list says List of safe, non-input html tags., but then 'input' was added to it, and I'm not sure whether that is a problem.

https://github.com/microsoft/vscode/blob/e5dfe045dbed2ebd6e7427e53e40a9f935b50318/src/vs/base/browser/dom.ts#L1863

alexr00 commented 6 months ago

I will defer to @mjbvz on this!

mjbvz commented 6 months ago

@alexr00 I don't think we should support it in hovers and other basic markdown places. Do you remember what feature it was originally added for?

alexr00 commented 6 months ago

Rendering read-only checkboxes in the comments widget.