search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.15k stars 28.05k forks source link

alt + f5 doesnt work for Goto Next Change, but Shift+Alt+F5 does, maybe PowerToys conflict #213230

Open tyeth opened 1 month ago

tyeth commented 1 month ago

Type: Bug

Open a changed file from source control, use Shift+ALT+F5 to move to previous change, then try Alt+F5 to move to next change (does nothing).

alt + f5 doesnt work for Goto Next Change, but Shift+Alt+F5 does, maybe PowerToys conflict

VS Code version: Code - Insiders 1.90.0-insider (405ce83a24f38fd70751b03438763a1503329fe0, 2024-05-20T23:10:16.407Z) OS version: Windows_NT x64 10.0.22000 Modes:

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|15.89GB (6.35GB free)| |Process Argv|--folder-uri file:///c%3A/Users/tyeth/source/repos/arduino/Adafruit_Wippersnapper_Arduino --crash-reporter-id 2f0dde31-9f97-4503-95e0-3b055142a7bb| |Screen Reader|no| |VM|0%|
Extensions (83) Extension|Author (truncated)|Version ---|---|--- azps-tools|azp|0.1.0 armview|ben|0.4.6 cpputest-test-adapter|bne|1.3.4 systemd-unit-file|coo|1.0.6 pdfpreview|cor|1.0.0 gitlens|eam|15.0.4 vscode-html-css|ecm|2.0.9 vsc-material-theme|Equ|33.2.0 vsc-material-theme-icons|equ|1.2.2 vscode-firefox-debug|fir|2.9.10 copilot|Git|1.194.886 copilot-chat|Git|0.16.2024052001 vscode-github-actions|git|0.26.2 vscode-pull-request-github|Git|0.89.2024051504 terraform|has|2.30.1 vscode-test-explorer|hbe|2.21.1 rest-client|hum|0.25.1 vscode-circuitpython|joe|0.2.0 VS-code-drupal|mar|0.0.12 cortex-debug|mar|1.12.1 debug-tracker-vscode|mcu|0.0.15 memory-view|mcu|0.0.25 peripheral-viewer|mcu|1.4.6 rtos-views|mcu|0.0.7 file-downloader|min|1.0.13 nc-gcode|ML|0.13.0 azure-pipelines|ms-|1.228.0 azure-dev|ms-|0.8.3 vscode-apimanagement|ms-|1.0.8 vscode-azureappservice|ms-|0.25.2 vscode-azurecontainerapps|ms-|0.7.0 vscode-azurefunctions|ms-|1.15.0 vscode-azureresourcegroups|ms-|0.9.0 vscode-azureserverlesspack|ms-|0.1.1 vscode-azurestaticwebapps|ms-|0.12.2 vscode-azurestorage|ms-|0.15.3 vscode-azurevirtualmachines|ms-|0.6.5 vscode-bicep|ms-|0.27.1 vscode-cosmosdb|ms-|0.22.0 vscode-docker|ms-|1.29.1 vscode-logicapps|ms-|1.2.9 csharp|ms-|2.30.28 vscode-dotnet-runtime|ms-|2.0.5 vscode-edge-devtools|ms-|2.1.5 playwright|ms-|1.1.5 black-formatter|ms-|2024.3.11371020 debugpy|ms-|2024.7.11371017 isort|ms-|2023.10.1 python|ms-|2024.7.11371014 vscode-pylance|ms-|2024.5.1 jupyter|ms-|2024.4.0 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.17 vscode-jupyter-cell-tags|ms-|0.1.9 vscode-jupyter-slideshow|ms-|0.1.6 remote-containers|ms-|0.366.0 remote-ssh|ms-|0.112.2024051615 remote-ssh-edit|ms-|0.86.0 remote-wsl|ms-|0.88.2 azure-account|ms-|0.12.0 azurecli|ms-|0.6.0 cpptools|ms-|1.20.5 remote-explorer|ms-|0.5.2024051509 test-adapter-converter|ms-|0.1.9 vscode-node-azure-pack|ms-|1.2.0 vscode-serial-monitor|ms-|0.11.240501001 vsliveshare|ms-|1.0.5918 azurerm-vscode-tools|msa|0.15.11 debugger-for-edge|msj|1.0.15 fix-json|oli|0.1.2 vscode-jest|Ort|6.2.5 vscode-nuget-gallery|pat|1.1.0 platformio-ide|pla|3.3.3 vscode-commons|red|0.0.6 vscode-yaml|red|1.14.0 ruby-lsp|Sho|0.6.10 unity-tools|Tob|1.2.12 intellicode-api-usage-examples|Vis|0.2.8 vscodeintellicode|Vis|1.3.1 vscode-icons|vsc|12.7.0 twig|wha|1.0.2 clang-format|xav|1.9.0 linkerscript|Zix|1.0.4
A/B Experiments ``` vsliv368cf:30146710 vspor879:30202332 vspor708:30202333 vspor363:30204092 tftest:31042121 vscod805:30301674 vsaa593:30376534 py29gd2263:31024238 c4g48928:30535728 2i9eh265:30646982 962ge761:30841072 pythongtdpath:30726887 welcomedialog:30812478 pythonidxpt:30768918 pythonnoceb:30776497 asynctok:30898717 dsvsc013:30777762 dsvsc014:30777825 dsvsc015:30821418 pythontestfixt:30866404 pythonregdiag2:30926734 pythonmypyd1:30859725 pythoncet0:30859736 2e7ec940:31000449 pythontbext0:30879054 accentitlementst:30870582 dsvsc016:30879898 dsvsc017:30880771 dsvsc018:30880772 cppperfnew:30980852 pythonait:30973460 showvideot:31016890 chatpanelt:31014475 01bff139:31013167 a69g1124:31018687 dvdeprecation:31040973 pythonprt:31036556 dwnewjupyter:31046869 nb_pri_only:31052048 26j00206:31048877 ```
lombervid commented 1 month ago

That has been happening to me for some time on my home computer (W11). But it works fine on my job computer (W10).

tyeth commented 1 month ago

Windows 11 is a pain, they mess with anything they like, like alt+spacebar a well used shortcut in many 3d apps.

Now my graphics keep jittering due to some new transparency driver rubbish.

Stay on 10 until they clutch it from your cold dead hands

On Sat, 25 May 2024, 07:37 lombervid, @.***> wrote:

That has been happening to me for some time on my home computer (W11). But it works fine on my job computer (W10).

— Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode/issues/213230#issuecomment-2130918807, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTBZ42XYR2ARRXCVJWGCWDZEAWR5AVCNFSM6AAAAABID2UNQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZQHEYTQOBQG4 . You are receiving this because you authored the thread.Message ID: @.***>

lszomoru commented 1 month ago

Could you please invoke the "Developer: Toggle Keyboard Shortcuts Troubleshooting" command from the command palette, reproduce the problem and then share the output. That should suffice to see whether the command is being invoked or not. Thanks!

lombervid commented 4 weeks ago

This is what I get:

2024-06-01 13:42:20.930 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-06-01 13:42:20.931 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-06-01 13:42:20.931 [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: AltLeft, keyCode: 18, key: Alt
2024-06-01 13:42:20.931 [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: AltLeft, keyCode: 6 ('Alt')
2024-06-01 13:42:20.931 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-06-01 13:42:21.480 [info] [KeybindingService]: + Ignoring single modifier alt due to it being pressed together with other keys.
mendhak commented 1 week ago

Doing the same, here's my output. I pressed it a few times. 

2024-06-22 14:15:58.974 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-06-22 14:15:58.992 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-06-22 14:15:58.992 [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: AltLeft, keyCode: 18, key: Alt
2024-06-22 14:15:58.993 [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: AltLeft, keyCode: 6 ('Alt')
2024-06-22 14:15:58.993 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-06-22 14:16:06.042 [info] [KeybindingService]: + Ignoring single modifier alt due to it being pressed together with other keys.
2024-06-22 14:16:06.375 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-06-22 14:16:06.375 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-06-22 14:16:06.375 [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: AltLeft, keyCode: 18, key: Alt
2024-06-22 14:16:06.376 [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: AltLeft, keyCode: 6 ('Alt')
2024-06-22 14:16:06.376 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-06-22 14:16:06.840 [info] [KeybindingService]: + Ignoring single modifier alt due to it being pressed together with other keys.
2024-06-22 14:16:11.522 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-06-22 14:16:11.543 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-06-22 14:16:11.543 [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: AltLeft, keyCode: 18, key: Alt
2024-06-22 14:16:11.543 [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: AltLeft, keyCode: 6 ('Alt')
2024-06-22 14:16:11.543 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-06-22 14:16:12.064 [info] [KeybindingService]: + Ignoring single modifier alt due to it being pressed together with other keys.
lszomoru commented 5 days ago

The commands that should be matched are:

Can you invoke the "Preferences: Open Keyboard Shortcuts" command from the command palette and search for these two commands. Are you seeing any keyboard shortcuts defined for them? This is what I have on my machine (macOS):

image
mendhak commented 5 days ago

Here's what I've got.

image

lszomoru commented 5 days ago

Those default keybindings look correct. Comparing your logs with what I have on my machine, I am not seeing any log entry that states that the "F5" key was pressed. Would you be able to look at the troubleshooting logs again, and just press "F5" and see if that appears in the logs. Is there a chance you have some kind of modifier that you have to press on your keyboard so that the function keys are dispatched?

mendhak commented 5 days ago

Gosh now I'm confused 😖

Yes I do have a modifier key, I'm using a Keychron K6 Pro. The Fn1 key is on the bottom row.

BUT. After I looked at the keyboard shortcut list, and then just now tried Alt+F5, it's started working. I'm Alt+F5ing away and it's doing what it should, and the keyboard shortcut logs are distinctly different, you can see it resolve alt+f5. 

2024-06-26 13:22:53.235 [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: AltLeft, keyCode: 18, key: Alt
2024-06-26 13:22:53.235 [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: AltLeft, keyCode: 6 ('Alt')
2024-06-26 13:22:53.235 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-06-26 13:22:53.248 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-06-26 13:22:53.248 [info] [KeybindingService]: | Resolving alt+F5
2024-06-26 13:22:53.248 [info] [KeybindingService]: \ From 2 keybinding entries, matched workbench.action.compareEditor.nextChange, when: textCompareEditorVisible, source: built-in.
2024-06-26 13:22:53.249 [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: F5, keyCode: 116, key: F5
2024-06-26 13:22:53.249 [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: F5, keyCode: 63 ('F5')
2024-06-26 13:22:53.249 [info] [KeybindingService]: | Resolving alt+F5
2024-06-26 13:22:53.249 [info] [KeybindingService]: \ From 2 keybinding entries, matched workbench.action.compareEditor.nextChange, when: textCompareEditorVisible, source: built-in.
2024-06-26 13:22:53.249 [info] [KeybindingService]: + Invoking command workbench.action.compareEditor.nextChange.
2024-06-26 13:22:53.539 [info] [KeybindingService]: + Ignoring single modifier alt due to it being pressed together with other keys.

Did the act of observing the keyboards shortcut list alter the outcome? This could be a Heisenbug.

So now I'm wondering about @lombervid setup.

lombervid commented 2 days ago

These are my shortcuts: image

And this is what I got with just F5:

2024-06-28 22:00:00.929 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-06-28 22:00:00.929 [info] [KeybindingService]: | Resolving F5
2024-06-28 22:00:00.930 [info] [KeybindingService]: \ From 3 keybinding entries, matched workbench.action.debug.start, when: debuggersAvailable && debugState == 'inactive', source: built-in.
2024-06-28 22:00:00.930 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: F5, keyCode: 116, key: F5
2024-06-28 22:00:00.930 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: F5, keyCode: 63 ('F5')
2024-06-28 22:00:00.930 [info] [KeybindingService]: | Resolving F5
2024-06-28 22:00:00.930 [info] [KeybindingService]: \ From 3 keybinding entries, matched workbench.action.debug.start, when: debuggersAvailable && debugState == 'inactive', source: built-in.
2024-06-28 22:00:00.930 [info] [KeybindingService]: + Invoking command workbench.action.debug.start.

My keyboard has a dedicated F Row (Keychron K8 Pro)