microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
161.02k stars 28.26k forks source link

Bolded font is not detected for custom font family #213282

Open tylerlaprade opened 2 months ago

tylerlaprade commented 2 months ago

Type: Bug

  1. On a MacBook, download both the regular and bold fonts here
  2. Set the editor font family to Comic Mono
  3. Set the theme to Quiet Light

Expected behavior: Keywords should be bolded Actual behavior: Keywords are not bolded

VS Code version: Code 1.89.1 (Universal) (dc96b837cf6bb4af9cd736aa3af08cf8279f7685, 2024-05-07T05:14:24.611Z) OS version: Darwin arm64 23.4.0 Modes:

System Info |Item|Value| |---|---| |CPUs|Apple M1 (8 x 24)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|3, 2, 2| |Memory (System)|8.00GB (0.08GB free)| |Process Argv|--crash-reporter-id 37778898-bdd9-47ac-ad8f-fad60f9eab0e| |Screen Reader|no| |VM|0%|
Extensions (84) Extension|Author (truncated)|Version ---|---|--- TabOut|alb|0.2.2 vim-cheatsheet|And|0.0.1 folder-source-actions|bie|0.2.1 multi-cursor-case-preserve|Car|1.0.5 turbo-console-log|Cha|2.10.4 ruff|cha|2024.22.0 package-json-upgrade|cod|2.1.2 csharpier-vscode|csh|1.7.2 datadog-vscode|dat|1.11.0 vscode-markdownlint|Dav|0.55.0 vscode-eslint|dba|2.4.4 es7-react-js-snippets|dsz|4.4.3 gitlens|eam|15.0.4 better-comments-next|edw|3.2.5 prettier-vscode|esb|10.4.0 figma-vscode-extension|fig|0.3.5 vscode-jest-runner|fir|0.4.73 code-runner|for|0.12.2 vscode-github-actions|git|0.26.2 vscode-pull-request-github|Git|0.88.1 gc-excelviewer|Gra|4.2.59 gti-vscode|Gra|0.6.1 dance|gre|0.5.14 vscode-test-explorer|hbe|2.21.1 iceworks-style-helper|ice|1.1.2 discord-vscode|icr|5.8.0 vscode-edit-csv|jan|0.9.1 vscode-requirements|jan|0.1.0 line-link|Kev|0.0.1 vsc-python-indent|Kev|1.18.0 vscode-sql-formatter|lea|2.1.6 rainbow-csv|mec|3.11.0 template-string-converter|meg|0.6.1 vscode-language-babel|mgm|0.0.40 dotenv|mik|1.0.1 inline-fold|moa|0.2.6 vscode-docker|ms-|1.29.1 csdevkit|ms-|1.6.8 csharp|ms-|2.30.28 vscode-dotnet-runtime|ms-|2.0.5 vscodeintellicode-csharp|ms-|2.1.11 debugpy|ms-|2024.6.0 flake8|ms-|2023.10.0 pylint|ms-|2023.10.1 python|ms-|2024.6.0 vscode-pylance|ms-|2024.5.1 remote-wsl|ms-|0.88.2 cmake-tools|ms-|1.17.17 cpptools|ms-|1.20.5 cpptools-extension-pack|ms-|1.3.0 test-adapter-converter|ms-|0.1.9 vscode-speech|ms-|0.8.0 vscode-typescript-next|ms-|5.5.20240505 vsliveshare|ms-|1.0.5918 abracadabra|nic|9.2.0 indent-rainbow|ode|8.3.1 vscode-jest|Ort|6.2.5 bun-vscode|ove|0.0.12 oxc-vscode|oxc|0.3.5 advanced-new-file|pat|1.2.2 vscode-react-refactor|pla|1.1.3 tsimporter|pmn|2.0.1 postman-for-vscode|Pos|1.0.2 quick-lint-js|qui|3.2.0 vscode-yaml|red|1.14.0 rust-analyzer|rus|0.3.1958 crates|ser|0.6.6 indenticator|Sir|0.7.0 vscode-fileutils|sle|3.10.3 sourcery|sou|1.18.0 code-spell-checker|str|3.0.1 vscode-stylelint|sty|1.4.0 svelte-vscode|sve|108.4.1 even-better-toml|tam|0.19.2 pypi-assistant|twi|2.0.5 cmake|twx|0.0.17 errorlens|use|3.17.0 learn-vim|vin|0.0.28 vscodeintellicode|Vis|1.3.1 vscode-icons|vsc|12.7.0 quokka-vscode|Wal|1.0.641 pretty-ts-errors|Yoa|0.5.4 fix-all-json|zar|0.1.5 ts-essential-plugins|zar|0.0.78 (2 theme extensions excluded)
A/B Experiments ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492:30256859 vscorecescf:30445987 vscod805:30301674 binariesv615:30325510 vsaa593cf:30376535 py29gd2263:31024239 c4g48928:30535728 azure-dev_surveyone:30548225 vscrp:30673768 962ge761:30959799 pythongtdpath:30769146 welcomedialogc:30910334 pythonidxpt:30866567 pythonnoceb:30805159 asynctok:30898717 pythontestfixt:30902429 pythonregdiag2:30936856 pythonmypyd1:30879173 pythoncet0:30885854 h48ei257:31000450 pythontbext0:30879054 accentitlementst:30995554 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 666c4381:30973075 chatpanelc:31048052 dsvsc021:30996838 bdiig495:31013172 pythoncenvptcf:31049071 fchga941:31046352 dvdeprecation:31052039 pythonprt:31056678 dwnewjupytercf:31046870 26j00206:31048877 ```
kenmcd commented 1 month ago

There are errors in the fonts. Names and weight settings are incorrect. And the vertical metrics are different in the two fonts.

So - not caused by an issue in VS Code