search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.11k stars 29.27k forks source link

Volume setting for signals? #213619

Open isidorn opened 5 months ago

isidorn commented 5 months ago

Testing #213344

Why are we in the business of configuring volume levels? IMHO this should be an OS thing - user can configure volume levels of every app.

meganrogge commented 5 months ago

I believe that was added by @hediet for audio cues.

hediet commented 5 months ago

We originally discussed introducing volume settings here: https://github.com/microsoft/vscode/issues/144771 I'm up for removing the setting though.

There is also https://github.com/microsoft/vscode/issues/202875, which is related.

isidorn commented 5 months ago

I am +1 to remove. Though I see it is in Stable already as you pointed out. So if we want to be safe we could opt in that setting to telemetry to see if any users actually changed it from the default value.

hediet commented 5 months ago

@meganrogge do you mind looking into this? If not, I can ask Alex to put it on the plan for me.

meganrogge commented 5 months ago

I will not get to this in June as I'm out for a few weeks and have other stuff. Would be great if you could add it to your plan 🙏🏼.

meganrogge commented 5 months ago

with https://github.com/microsoft/vscode/pull/214163, we can now get telemetry for this