search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.16k stars 28.53k forks source link

Notebook keybindings for insert cell above and below are not mentioned #213641

Closed ulugbekna closed 1 month ago

ulugbekna commented 3 months ago

Testing #213343

  1. Focus on a notebook cell
  2. Press alt+f1 to bring accesibility help
  3. See keybindings for "insert cell above/below" missing; neither setting a keybinding is mentioned

Image

meganrogge commented 3 months ago

this is because those don't support keybindings I believe ? cc @amunger

amunger commented 3 months ago

I think I was trying to reduce the verbosity by combining those related commands, but multiple commands weren't available in the template

meganrogge commented 3 months ago

Not sure what you mean 🤔 ... what template?

amunger commented 3 months ago

There used to be a helper function when this was added, https://github.com/microsoft/vscode/pull/186229/files looks like it's just text now

meganrogge commented 3 months ago

oh, I must've missed replacing it with the <keybinding:commandId> when I did that refactor

vs-code-engineering[bot] commented 1 month ago

Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the insiders-released label directly, or comment \closedWith someShaThatWillbeReleasedWhenThisIsRelesed.

karthiknadig commented 1 week ago

image