microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.98k stars 28.78k forks source link

Single replace (in find editor widget) not working with regex pattern using lookbehind #213897

Closed TristanM42 closed 1 month ago

TristanM42 commented 4 months ago

Type: Bug

Similar issues :

Environment :

Tested with my vscode + Insiders with no extensions + tested from github integrated vscode

Insider version : Version: 1.90.0-insider (user setup) Commit: bc15ede705b9168324a3440b7c80c80644743306 Date: 2024-05-30T05:53:01.333Z (3 hrs ago) Electron: 29.4.0 ElectronBuildld: 9593362 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0.22631

My vscode version : Version: 1.89.1 (user setup) Commit: dc96b837cf6bb4af9cd736aa3af08cf8279f7685 Date: 2024-05-07T05:13:33.891Z (3 wks ago) Electron: 28.2.8 ElectronBuildld: 27744544 Chromium: 120.0.6099.291 Node.js: 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0.22631

My PC : Edition Windows 11 Professionnel Version 23H2 Installed ‎20/‎02/‎2024 OS Build 22631.3593 Windows Feature Experience Pack 1000.22700.1003.0

Steps to reproduce :

Paste this example in a new file :

CustomButton {
    totalStep : 1
    state1Text: "New Exam"
    state1TextColor: "#191b25"
    state1BGColor: "#07BE8E"
    anchors.centerIn: parent
}

single replace not working with : (?<=\n)( state) (?<=(1|")\n)( state)

single replace works with: (?<=1\n)( state)

It seems that it's not working when more than one match is found.

Note : single replacement using search and replace in files has not this issue.

VS Code version: Code - Insiders 1.90.0-insider (bc15ede705b9168324a3440b7c80c80644743306, 2024-05-30T05:53:01.333Z) OS version: Windows_NT x64 10.0.22631 Modes:

System Info |Item|Value| |---|---| |CPUs|11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz (16 x 2304)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|15.71GB (3.83GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Extensions: none
A/B Experiments ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vstes627:30244334 vsc_aa:30263845 vscod805:30301674 vsaa593cf:30376535 py29gd2263:31024238 vscaac:30438845 c4g48928:30535728 962ge761:30841072 pythongtdpath:30726887 welcomedialog:30812478 pythonidxpt:30768918 pythonnoceb:30776497 asynctok:30898717 dsvsc013:30777762 dsvsc014:30777825 dsvsc015:30821418 pythontestfixt:30866404 pythonregdiag2:30926734 pythonmypyd1:30859725 pythoncet0:30859736 h48ei257:31000450 pythontbext0:30879054 accentitlementst:30870582 dsvsc016:30879898 dsvsc017:30880771 dsvsc018:30880772 cppperfnew:30980852 pythonait:30973460 showvideot:31016890 chatpanelt:31014475 bdiig495:31013172 a69g1124:31018687 dvdeprecation:31040973 pythonprt:31036556 dwnewjupytercf:31046870 impr_priority:31057980 26j00206:31048877 ```
VSCodeTriageBot commented 3 months ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

spartanatreyu commented 3 months ago

Might be related to issue: https://github.com/microsoft/vscode/issues/212562

vs-code-engineering[bot] commented 2 months ago

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

vs-code-engineering[bot] commented 1 month ago

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!