`activeEditorGroupLast` is not working anymore

[freder]

Type: Bug

1. open vscode
2. add a new editor group on the right
3. open a file in the right group
4. do Developer: Inspect Context Keys via command palette
5. look at object in developer tools and confirm that activeEditorGroupLast is false, when it should actually be true

VS Code version: Code 1.89.1 (dc96b837cf6bb4af9cd736aa3af08cf8279f7685, 2024-05-07T05:14:32.757Z) OS version: Darwin arm64 22.6.0 Modes:

System Info

|Item|Value| |---|---| |CPUs|Apple M2 Pro (10 x 24)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|3, 2, 2| |Memory (System)|32.00GB (0.05GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|

Extensions (83)

Extension|Author (truncated)|Version ---|---|--- project-manager|ale|12.8.0 indent-jump|aPi|1.0.1 vscode-apollo|apo|1.20.0 vscode-django|bat|1.15.0 calva|bet|2.0.454 calva-spritz|bet|1.0.5 markdown-mermaid|bie|1.23.0 vscode-intelephense-client|bme|1.10.4 glsl-canvas|cir|0.2.15 sqlnotebook|cmo|0.7.0 vscode-eslint|dba|2.4.4 binary-plist|dni|0.11.3 vscode-glsllint|dto|1.8.1 gitlens|eam|15.0.4 permute-lines|ear|1.1.0 EditorConfig|Edi|0.16.4 vscode-great-icons|emm|2.1.105 filter-line|eve|2.0.1 vscode-open-in-finder|fab|2.0.3 vscode-todo-plus|fab|4.19.1 vscode-metapost|fje|0.1.6 kotlin|fwc|0.2.34 copilot|Git|1.197.0 copilot-chat|Git|0.15.2 copilot-labs|Git|0.17.1121 go|gol|0.41.4 gc-excelviewer|Gra|4.2.59 haskell|has|2.4.4 haskell-linter|hoo|0.0.6 plantuml|jeb|2.18.1 language-haskell|jus|3.6.0 nim|kos|0.6.6 graphql-for-vscode|kum|1.15.3 likec4-vscode|lik|1.1.1 vscode-clangd|llv|0.1.28 call-graph|Luo|1.2.1 string-manipulation|mar|0.5.7 markwhen|Mar|1.4.2 slugify-vscode|max|1.1.0 rainbow-csv|mec|3.12.0 vex|mel|0.6.0 vscode-language-babel|mgm|0.0.40 vscode-apache|mrm|1.2.0 debugpy|ms-|2024.6.0 isort|ms-|2023.10.1 python|ms-|2024.6.0 vscode-pylance|ms-|2024.5.1 jupyter|ms-|2024.4.0 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.17 vscode-jupyter-cell-tags|ms-|0.1.9 vscode-jupyter-slideshow|ms-|0.1.6 cmake-tools|ms-|1.18.41 cpptools|ms-|1.20.5 hexeditor|ms-|1.10.0 sublime-keybindings|ms-|4.1.10 explorer-exclude|Pet|1.3.2 pokowaka-iwyu|pok|1.0.3 java|red|1.31.0 rust-analyzer|rus|0.3.1983 crates|ser|0.6.6 markdown-preview-enhanced|shd|0.8.13 shopify-liquid|sis|4.0.1 vscode-fileutils|sle|3.10.3 shader|sle|1.1.5 swift-lang|ssw|1.9.0 vscode-rustfmt|sta|0.2.0 shader-toy|ste|0.11.2 vscode-styled-components|sty|1.7.8 svelte-vscode|sve|108.5.0 even-better-toml|tam|0.19.2 cmantic|tde|0.9.0 vscode-markdown-paste-image|tel|1.0.2 d2|Ter|0.8.8 graphviz-interactive-preview|tin|0.3.5 go-to-method|tri|0.2.0 cmake|twx|0.0.17 lorem-ipsum|Tyr|1.3.1 vscode-lldb|vad|1.10.0 vscode-todo-highlight|way|1.0.5 twig|wha|1.0.2 vscode-nginx|wil|0.7.2 change-case|wma|1.0.0

[freder]

background

this keybinding used to work, but now doesn't anymore as of one of the recent versions:

{
    "key": "alt+d",
    "command": "editor.action.revealDefinitionAside",
    "when": "editorHasDefinitionProvider && editorTextFocus && !isInEmbeddedEditor && activeEditorGroupLast!=true"
    // activeEditorGroupLast!=true so that we never add a new pane/column
}, {
    "key": "alt+d",
    "command": "editor.action.revealDefinition",
    "when": "editorHasDefinitionProvider && editorTextFocus && !isInEmbeddedEditor && activeEditorGroupLast==true"
},

[bpasero]

Maybe related to some recent context key work from @benibenj

[benibenj]

@freder Can you check the newest vscode version? We made changes in the latest release which might have fixed this issue

[freder]

works again 👍