microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.11k stars 28.82k forks source link

Add `open in search panel` option to floating find widget #214298

Open RichardLuo0 opened 4 months ago

RichardLuo0 commented 4 months ago

Similar to open results in find window in Android Studio. Just for convenience.

andreamah commented 4 months ago

We don't have floating widgets for many functionalities, so I don't think that we'd end up making the search panel floating. But you could try workbench.action.quickTextSearch to get a 'floating' picker to find items.

VSCodeTriageBot commented 4 months ago

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

RichardLuo0 commented 4 months ago

We don't have floating widgets for many functionalities, so I don't think that we'd end up making the search panel floating. But you could try workbench.action.quickTextSearch to get a 'floating' picker to find items.

I think you may be misunderstanding. I am not trying to make the search panel floating. I mean in this widget: image add an option that lets me open the search result in the search panel: image The reason is that the search panel lists all available results and is clearer when you have a single huge file.

Certainly, you can just use the search panel. But then you have to write the glob expression in include files(assume you need to search only in this file). So for convenience, add an option to the search widget, that allows us to open the results directly in the search panel.

In fact similar function is implemented in Android Studio as well. image It opens this: image

andreamah commented 4 months ago

So you want to see the results of the find widget in a panel? If you use Quick Search, the results from the current file should be shown first, if that helps.

RichardLuo0 commented 4 months ago

Quick Search is across files, which is different from the search widget which searches the current file only.

andreamah commented 4 months ago

It will list the current file's matches first. Otherwise, if that's not sufficient, I'll pass this over to the feature owner for the find widget.