microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
161.97k stars 28.47k forks source link

Ruler in notebook cells should extend to the border of the cell (not just the invisible end of the editor) #215517

Open rehmsen opened 2 months ago

rehmsen commented 2 months ago

Does this issue occur when all extensions are disabled?: Yes/No

Steps to Reproduce:

  1. Configure a ruler, e.g. with
    "editor.rulers": [
        80
    ]
  2. Open a notebook file e.g. /Users/oler/Code/vscode/extensions/vscode-api-tests/testWorkspace/test.ipynb

Actual:

image

Expected:

The ruler should probably extend to the end of the cell. I think it's because the actual editor is only those two lines, and then there is a status bar with the language. But visually it looks a bit broken because the editor has no bottom boundary, so stopping the ruler there is weird.

rebornix commented 2 months ago

Agree that it looks out of place.

Currently the cell status bar is rendered next to the cell editor, maybe we could explore setting a padding bottom in the text editor, and then render the cell status bar on top of the text editor with a higher zindex.