microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.37k stars 29.32k forks source link

'undo' does not work in jupyter notebook cells #215748

Closed misha-antonenko closed 3 weeks ago

misha-antonenko commented 5 months ago

Type: Bug

at some point it simply stopped working when a cell is focussed

the symptoms are as in https://github.com/microsoft/vscode/issues/133026

VS Code version: Code 1.90.1 (Universal) (611f9bfce64f25108829dd295f54a6894e87339d, 2024-06-11T21:02:41.372Z) OS version: Darwin arm64 23.4.0 Modes: Remote OS version: Linux x64 5.10.0-1057-oem

System Info |Item|Value| |---|---| |CPUs|Apple M2 (8 x 2400)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|2, 2, 2| |Memory (System)|16.00GB (0.15GB free)| |Process Argv|| |Screen Reader|no| |VM|0%| |Item|Value| |---|---| |Remote|SSH: etna| |OS|Linux x64 5.10.0-1057-oem| |CPUs|Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz (128 x 1232)| |Memory (System)|1007.49GB (986.26GB free)| |VM|0%|
Extensions (101) Extension|Author (truncated)|Version ---|---|--- language-x86-64-assembly|13x|3.1.4 Bookmarks|ale|13.5.0 coder-remote|cod|1.0.2 apc-extension|drc|0.3.9 remotehub|Git|0.62.0 vsc-python-indent|Kev|1.18.0 kconfig|luv|1.0.3 jupyter-keymap|ms-|1.1.2 remote-containers|ms-|0.369.0 remote-ssh|ms-|0.112.0 remote-ssh-edit|ms-|0.86.0 vscode-remote-extensionpack|ms-|0.25.0 azure-repos|ms-|0.38.0 remote-explorer|ms-|0.4.3 remote-repositories|ms-|0.40.0 remote-server|ms-|1.5.2 scala|sca|0.5.7 semanticdiff|sem|0.8.10 ayu|tea|1.0.5 pdf|tom|1.2.2 errorlens|use|3.18.0 jinja|who|0.0.8 linkerscript|Zix|1.0.4 language-x86-64-assembly|13x|3.1.4 vscode-sql-formatter|adp|1.4.4 Bookmarks|ale|13.5.0 vscode-tlaplus|aly|1.5.4 vscode-django|bat|1.15.0 vscode-bazel|Baz|0.10.0 ruff|cha|2024.26.0 flip|Chr|0.0.4 close-tabs-to-the-left|ctf|0.0.4 python-environment-manager|don|1.2.4 python-extension-pack|don|1.7.0 gitlens|eam|15.1.0 EditorConfig|Edi|0.16.4 pyre-vscode|fb-|0.0.2 shell-format|fox|7.2.5 flatbuffers|gab|0.1.0 copilot|Git|1.203.0 copilot-chat|Git|0.16.1 remotehub|Git|0.62.0 vscode-pull-request-github|Git|0.88.1 go|gol|0.41.4 terraform|has|2.30.2 dvc|ite|1.2.13 jbockle-format-files|jbo|3.4.0 list-symbols|jmb|0.0.5 nix-ide|jno|0.3.1 vsc-python-indent|Kev|1.18.0 vscode-cython|ktn|1.0.3 lean4|lea|0.0.160 vscode-clangd|llv|0.1.28 vscode-mlir|llv|0.0.11 kconfig|luv|1.0.3 rainbow-csv|mec|3.12.0 markdown-formatter|mer|0.9.7 git-graph|mhu|1.30.0 vscode-docker|ms-|1.29.1 debugpy|ms-|2024.6.0 isort|ms-|2023.10.1 python|ms-|2024.8.1 vscode-pylance|ms-|2024.6.1 jupyter|ms-|2024.5.0 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.18 vscode-jupyter-cell-tags|ms-|0.1.9 vscode-jupyter-slideshow|ms-|0.1.6 azure-repos|ms-|0.38.0 cpptools|ms-|1.20.5 hexeditor|ms-|1.10.0 makefile-tools|ms-|0.9.10 remote-repositories|ms-|0.40.0 autodocstring|njp|0.6.1 vscode-pbkit|pbk|0.0.7 vscode-auto-scroll|pej|1.2.0 java|red|1.31.0 vscode-xml|red|0.27.1 vscode-yaml|red|1.15.0 rust-analyzer|rus|0.3.1995 scala|sca|0.5.7 metals|sca|1.35.0 semanticdiff|sem|0.8.10 markdown-preview-enhanced|shd|0.8.13 bazel-stack-vscode|Sta|1.9.8 even-better-toml|tam|0.19.2 ayu|tea|1.0.5 errorlens|use|3.18.0 vscode-lldb|vad|1.10.0 intellicode-api-usage-examples|Vis|0.2.8 vscodeintellicode|Vis|1.3.1 vscode-java-debug|vsc|0.57.0 vscode-java-dependency|vsc|0.23.6 vscode-java-pack|vsc|0.27.0 vscode-java-test|vsc|0.41.1 vscode-maven|vsc|0.44.0 jinja|who|0.0.8 clang-format|xav|1.9.0 save-as-root|yy0|1.8.0 symlink-follow|zau|1.0.3 linkerscript|Zix|1.0.4 (4 theme extensions excluded)
misha-antonenko commented 5 months ago

it is as if i cannot undo the changes that have been saved by cmd-s or autosave

misha-antonenko commented 5 months ago

is there a quick (and possibly ugly) remedy for this? it becomes too easy to throw away work in such conditions

DonJayamanne commented 4 months ago

@misha-antonenko please can you provide steps to replicate this issue

vscodenpa commented 4 months ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

misha-antonenko commented 3 months ago

@DonJayamanne

  1. open a remote Jupyter notebook with a remote kernel
  2. make some modifications to a cell
  3. try to undo and fail

fwiw, i have "files.autoSave": "afterDelay" with "files.autoSaveDelay": 500

misha-antonenko commented 3 months ago

"notebook.undoRedoPerCell": false

misha-antonenko commented 3 months ago

have not managed to reproduce with "notebook.undoRedoPerCell": true

vs-code-engineering[bot] commented 3 weeks ago

Hey @rebornix @DonJayamanne, this issue might need further attention.

@misha-antonenko, you can help us out by closing this issue if the problem no longer exists, or adding more information.

DonJayamanne commented 3 weeks ago

Given that you can no longer repro this issue, I'm closing this issue for now