microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.28k stars 28.09k forks source link

default terminal remains pwsh after changing default terminal to bash #216591

Open uaxpasha opened 2 weeks ago

uaxpasha commented 2 weeks ago

Type: Bug

Default profile changed to bash. In settings.json terminal.integrated.defaultProfile.windows: "Git Bash", but vs code still opens pwsh terminal on default

workaround that didn't help: "terminal.integrated.profiles.windows": { "PowerShell": null, "Git Bash": { "source": "Git Bash" }, "Windows PowerShell": null }, "powershell.enableProfileLoading": false, "powershell.integratedConsole.showOnStartup": false,

VS Code version: Code 1.89.1 (dc96b837cf6bb4af9cd736aa3af08cf8279f7685, 2024-05-07T05:13:33.891Z) OS version: Windows_NT x64 10.0.22631 Modes:

System Info |Item|Value| |---|---| |CPUs|11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 1805)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|31.40GB (16.64GB free)| |Process Argv|--crash-reporter-id 5df5fa60-faad-41f5-92d9-039d5b12c603| |Screen Reader|no| |VM|0%|
Extensions (31) Extension|Author (truncated)|Version ---|---|--- swagger-viewer|Arj|3.1.2 path-intellisense|chr|2.9.0 vscode-markdownlint|Dav|0.55.0 vscode-eslint|dba|3.0.8 githistory|don|0.6.20 gitlens|eam|15.1.0 prettier-vscode|esb|10.4.0 markdown-table-formatter|fcr|3.0.0 dotnet-test-explorer|for|0.7.8 batch-rename-extension|Jan|0.0.6 typelens|kis|1.10.0 protractor-test-runner|luc|1.1.0 prettify-json|moh|0.0.3 csharp|ms-|2.33.17 vscode-dotnet-runtime|ms-|2.0.6 playwright|ms-|1.1.7 powershell|ms-|2024.2.2 material-icon-theme|PKi|5.4.2 tsimporter|pmn|2.0.1 vscode-yaml|red|1.15.0 json-organizer|rin|0.0.4 LiveServer|rit|5.7.9 sonarlint-vscode|Son|4.6.0 code-spell-checker|str|3.0.1 open-in-browser|tec|2.0.0 explorer-manager|Uro|1.0.1 tab-groups|usa|2.1.1 vscode-icons|vsc|12.8.0 quokka-vscode|Wal|1.0.646 JavaScriptSnippets|xab|1.8.0 markdown-pdf|yza|1.5.0
A/B Experiments ``` vsliv368cf:30146710 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscoreces:30445986 vscod805cf:30301675 binariesv615:30325510 vsaa593cf:30376535 py29gd2263:31024239 c4g48928:30535728 azure-dev_surveyone:30548225 a9j8j154:30646983 962ge761:30959799 pythongtdpath:30769146 welcomedialog:30910333 pythonidxpt:30866567 pythonnoceb:30805159 asynctok:30898717 pythontestfixt:30902429 pythonregdiag2:30936856 pythonmypyd1:30879173 2e7ec940:31000449 pythontbext0:30879054 accentitlementst:30995554 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 jchc7451:31067544 chatpanelc:31048052 dsvsc021:30996838 bdiig495:31013172 pythoncenvpt:31062603 a69g1124:31058053 dvdeprecation:31068756 pythonprt:31056678 dwnewjupytercf:31046870 legacy_priority:31077528 ```
VSCodeTriageBot commented 2 weeks ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.90.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

uaxpasha commented 2 weeks ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.90.1. Please try upgrading to the latest version and checking whether this issue remains.

Can't update, there's no update now button in vs code.

meganrogge commented 2 weeks ago

where is git bash on your computer?

meganrogge commented 2 weeks ago

guessing the file path is different than the one we expect

uaxpasha commented 2 weeks ago

where is git bash on your computer?

C:\Program Files\Git\git-bash.exe

tried also this "terminal.integrated.shell.windows": "C:\Program Files\Git\git-bash.exe", but seems that terminal.integrated.shell.windows was deprecated

meganrogge commented 2 weeks ago

try:

"Git Bash 2": {
"path": "C:\Program Files\Git\git-bash.exe"
},