search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.61k stars 29.03k forks source link

Target size of "Copy collaboration link" and "Stop collaboration session" button is 20*20px, which is less than 24x24px: A11y_Visual Studio Code_"Session Details ", "Help" sections_Target Size #216783

Closed kapilvaishna closed 4 months ago

kapilvaishna commented 4 months ago

Please do not close this bug. This bug should only be closed by Trusted Tester after verification. "Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier."

Environment Details:

Application Name: Visual Studio Code Edition Windows 11 Enterprise Version 23H2 OS build 22631.3737 Visual Studio code Version 1.89.1

GitHub Tags:

A11yTCS; #A11ySev2; #WCAG2.5.8; #DesktopApp; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Jan2024; #FTP; #Win32; #A11yMAS; #A11yWCAG2.2; #TargetSize; #NeedToDiscuss; #Closed;

Repro Steps:

  1. Open visual studio code application.
  2. Install "Live share" extension.
  3. TAB till "Share read/write" control and hit ENTER.
  4. TAB till "Session Details" in left navigation.
  5. TAB till "Copy collaboration link" and "Stop collaboration session" button.
  6. Observe that Target size of "Copy collaboration link" and "Stop collaboration session" button is 20*20px, which is less than 24x24px.

Actual Result:

Target size of "Copy collaboration link" and "Stop collaboration session" button is 20*20px, which is less than 24x24px.

Expected Result:

Target size of "Copy collaboration link", and "Stop collaboration session" button should be minimum 24x24pixel. If the controls have spaced in-between, then those spaces should not intersect each other and target size with spacing should be 24x24 pixel for each one.

User Impact:

Users with dexterity limitations and those who have difficulty with fine motor movement find it difficult to accurately activate small targets when there are other targets that are too close. Providing sufficient size, or sufficient spacing between targets, will reduce the likelihood of accidentally activating the wrong control.

Attachment

https://github.com/microsoft/vscode/assets/124254981/8d7c0a63-9c6f-4fdc-a527-edc5dcfba872

216783_Copy collabration link

216783_Stop collaboration session

local size properly attachment

216783_VS Code target size

216783_Target size

Yash14j commented 4 months ago

GithubTags: #Rev:yaja;

kapilvaishna commented 4 months ago

Logged to track bug https://github.com/microsoft/vscode/issues/209934 since old bug is locked.

alexr00 commented 4 months ago

Closing a duplicate of the previous bug https://github.com/microsoft/vscode/issues/209934

Please reach to Isidor on Teams.

kapilvaishna commented 3 months ago

Verify the issue with ruler scale and for both control logical size is 20*20 px and 4 px space is there between the control so closing the bug. Attachment:

https://github.com/user-attachments/assets/4a03db5c-0e22-4e7b-a512-b16bde9b2aaf