microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.4k stars 29.33k forks source link

There are two stop buttons in inline chat #217845

Open alexr00 opened 4 months ago

alexr00 commented 4 months ago

Testing: https://github.com/microsoft/vscode/issues/217202

image
jrieken commented 4 months ago

In text btn mode we hide it from the input box but I wasn't brave enough to change this for normal mode...

@daviddossett what do you think?

daviddossett commented 4 months ago

I'm trying to figure out what's happening here—it looks like a mix of the old and new modes? The setting seems to have no effect for me at the moment (I can only see the new text button mode now).

Is the screenshot above in the old mode then?

jrieken commented 4 months ago

The setting seems to have no effect for me at the moment (I can only see the new text button mode now).

Changing the setting requires a reload.

I'm trying to figure out what's happening here—it looks like a mix of the old and new modes?

Kinda - when the setting is off we have the same/similar new button layout/arrangement but the "old" rendering style

jrieken commented 4 months ago

Changing the setting requires a reload.

Pushing a change to remove that limitation... This was getting annoying for development

jrieken commented 4 months ago

Really unsure what to do here. I see how two buttons aren't ideal, but this is my reasoning

We could hide the bar again (in traditional mode) but that was always buggy when doing more than one request and I also moved the "View in Chat" command into the bottom bar (to avoid having action items next to the input box too) which is now accessible in the overflow menu (and which I don't wanna make overly prominent). I think there is two options

  1. leave it as today
  2. only show the overflow btn while a request is active

This is how 2 looks

https://github.com/user-attachments/assets/733c87e7-9630-452e-bca4-e32ea2e8b2a2

daviddossett commented 4 months ago

I think it makes sense to keep both for the moment. Ideally this is a short-term issue assuming we switch over to the new mode as the default.