microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.52k stars 28.1k forks source link

Profiles Editor: align with form layout/settings UI #218162

Open daviddossett opened 1 week ago

daviddossett commented 1 week ago

Testing #217139

Related to other feedback I've given, here's a quick sketch of what I think gets us more aligned with things like the settings UI. Ideally we could even reuse the basic settings UI under the hood, but I don't know how portable it is off the top of my head. This isn't totally thought through but hopefully conveys the general idea I had in mind.

Main talking points:

CleanShot 2024-06-25 at 11 06 49@2x

sandy081 commented 1 week ago

Thanks for the feedback. I like it is aligned with Settings UI and will incorporate these changes in the next milestone.

sandy081 commented 1 week ago

Regarding primary actions on the profile in the LHS, I think New Window should be the only primary action and other should be in the overflow.