search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.88k stars 28.23k forks source link

Accessibility: "Dark high contrast theme" cursor disappears and stops blinking after a time #219138

Open esajic-ct opened 3 weeks ago

esajic-ct commented 3 weeks ago

I am using VSCode in MS Edge. I have eyesight issues so I need to use dark mode. When I use the "Dark high contrast theme" the cursor is not visible. When I first click in the code I see the cursor blinking, but then that stops and I have no idea where the cursor is.

People using the high contrast themes are usually doing it because they find it difficult to see, and the cursor is particularly difficult to see anyway.

Please can these themes be made more accessible. It would be a lot better if the cursor was a thicker line. It is good that the cursor is a bright colour such as bright white. In fact, making the cursor thicker (and brighter if it's not already) would be good, not just on the high contrast themes but on the other themes too (especially the dark themes).

Cursor on the screenshot is at the end of line 12 but there is no way of knowing because it's not visible.

image

Version: 1.90.2 Commit: 5437499feb04f7a586f677b155b039bc2b3669eb User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0 Embedder: vscode.dev

meganrogge commented 2 weeks ago

When your focus is in the editor, the cursor will be visible. I believe in your screenshot, it's not showing up because your editor is not focused.

Perhaps we should make the editor.cursorStyle (and the one for the terminal) block by default in high contrast themes. @daviddossett what do you think?

esajic-ct commented 6 days ago

@meganrogge I like the idea of having a block cursor by default in high contrast themes, I reckon this would be a lot easier for me to see.

meganrogge commented 6 days ago

Also cc @isidorn for thoughts

isidorn commented 5 days ago

Overall this makes sense. But we do not have a concept of default setting values based on other settings (value for theme). @esajic-ct for now you can manually change the cursor style to be block. And I suggest we keep this issue open to gather more feedback, before we make the change for all the HC theme users.