search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.44k stars 28.1k forks source link

tokenColorCustomizations SCOPE NEEDED #219153

Open Dpschu2 opened 1 week ago

Dpschu2 commented 1 week ago

Can a new token color scope be added for css attribute values? Currently it is selectable if the value is a string, but if is not a string, then it cannot be differentiated from the attribute key. This is of course needed to set the color separate from the key.

example (Example where 'something' is not scoped differently)

aeschli commented 4 days ago

This is what I see with the latest insiders and the Dark Modern Theme (Default)

Image

Maybe the issue is with the theme you are using? Which on is it? If it is a theme from an extension, please file the issue against that extension.

.blog-caption[data=something] {
    p {
        background-color: #f00;
    }
}
Dpschu2 commented 4 days ago

I am using my own color theme extension: Future Dark

https://marketplace.visualstudio.com/items?itemName=deans4.future-dark

I tested on other color themes, and they are all like that: image

It could possibly by an issue cause by a different extension.. I will try disabling my syntax extensions and reply with the results.

Dpschu2 commented 4 days ago

Found the culprit: https://marketplace.visualstudio.com/items?itemName=dannymcgee.vscode-scss-lang

Beware!!!