v1.91 does not launch on Catalina or Big Sur due to Fatal error in V8

msimms commented 3 weeks ago

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.91
OS Version: Mac OS Catalina

Steps to Reproduce:

Launch 1.91 on Mac OS Catalina, VSCode will crash. If you try launching from the command line, you'll see the following error: "Fatal error in V8: v8::Template::Set Invalid value, must be a primitive or a Template"

I know this is an old version of Mac OS, but if an OS will no longer be supported then perhaps it shouldn't update automatically. This particular installation is a developer test machine that won't/can't be updated past Catalina.

bitfield commented 2 weeks ago

Can users additionally help verify if the following builds based on 1.91.1 address the issue,

Apple Intel Apple Silicon Universal

Not working on 10.15.7.

deepak1556 commented 2 weeks ago

@bitfield please share the output of <Path to downloaded App>/Contents/Resources/app/bin/code --version and <Path to downloaded App>/Contents/Resources/app/bin/code --verbose

bbartlett commented 2 weeks ago

Can users additionally help verify if the following builds based on 1.91.1 address the issue,

Apple Intel Apple Silicon Universal

It is now working fine on Big Sur 11.7.10. Thanks!

melectronics-it commented 2 weeks ago

Also working on Big Sur 11.7.10. Thanks for the fixing :)

lomars commented 2 weeks ago

Can users additionally help verify if the following builds based on 1.91.1 address the issue,

Apple Intel Apple Silicon Universal

I confirm That this revised V1.91 works on MacOS Catalina (version 10.15.7)… Thanks for the fix 👍 😄

sugapablo commented 2 weeks ago

Can users additionally help verify if the following builds based on 1.91.1 address the issue,

Apple Intel Apple Silicon Universal

Works: Version: 1.91.1 (Universal) Commit: 8dc116235926cec63663b828d083c236fc66c2d3 Date: 2024-07-08T21:09:59.389Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin x64 20.6.0

bitfield commented 2 weeks ago

@bitfield please share the output of <Path to downloaded App>/Contents/Resources/app/bin/code --version and <Path to downloaded App>/Contents/Resources/app/bin/code --verbose

Correction, this is now working for me. I must have been looking at the wrong download before.

alexchee commented 2 weeks ago

Can confirm that now I am able to launch and use this version (1.91.1) on my Intel Macbook running on Big Sur, when version 1.91.0 would have the same error and crash.

Works: vscode version: 1.91.1 (Apple Intel) OS: Darwin 11.7.10 (20G1427)

yenaingtun-dev commented 2 weeks ago

i still have the same problem on Catalina 1.91.1.

charlie83xt commented 2 weeks ago

Not working for me. Catalina 10.15.7

wy353208214 commented 2 weeks ago

can't open with 1.91.1

OS: Big Sur 11.6
vscode version: 1.91.1

TheTridentGuy commented 2 weeks ago

Same issue on MacOS 10.15 Catalina.

deepak1556 commented 2 weeks ago

@yenaingtun-dev @wy353208214 please share the output of <Path to downloaded App>/Contents/Resources/app/bin/code --version and <Path to downloaded App>/Contents/Resources/app/bin/code --verbose

sirlluis commented 2 weeks ago

Same problem with Big Sur 11.7.10 Intel chip, seems work with older versions.

wy353208214 commented 2 weeks ago

Upgrade in two ways, but still can't open:

download 1.91.1 from https://code.visualstudio.com/updates/v1_91. i copied it to the application directory and replaced the old version.
update with vscode 1.90.2

but code --version showed 1.91.0?

./code --version
[0710/093925.579577:ERROR:codesign_util.cc(109)] SecCodeCheckValidity: Error Domain=NSOSStatusErrorDomain Code=-67062 "(null)" (-67062)
1.91.0
ea1445cc7016315d0f5728f8e8b12a45dc0a7286
x64

/code --verbose
[0710/094003.591481:ERROR:codesign_util.cc(109)] SecCodeCheckValidity: Error Domain=NSOSStatusErrorDomain Code=-67062 "(null)" (-67062)
[main 2024-07-10T01:40:04.751Z] [File Watcher (node.js)] Request to start watching: /Users/steven/Library/Application Support/Code/User (excludes: <none>, includes: <all>, filter: <none>, correlationId: <none>),/Users/steven/Library/Application Support/Code/User/settings.json (excludes: <none>, includes: <all>, filter: <none>, correlationId: <none>)
[99297:0710/094004.802823:ERROR:node_bindings.cc(162)] Fatal error in V8: v8::Template::Set Invalid value, must be a primitive or a Template
[0710/094005.079798:WARNING:crash_report_exception_handler.cc(235)] UniversalExceptionRaise: (os/kern) failure (5)
[0710/094005.080072:ERROR:directory_reader_posix.cc(43)] opendir /Users/steven/Library/Application Support/Code/Crashpad/attachments/a3b09d09-7ab2-4641-8868-f5c74259dba4: No such file or directory (2)

alexkuc commented 2 weeks ago

Those who downgrade and say it still doesn't open, did you disable auto update of VSCode by any chance? By default, VS Code will auto update so even if initial launch was with previous version, that might be enough time for VS to download upgrade so next time the latest version is launched. Here's instructions on how to disable auto-update in VSCode.

tategakibunko commented 2 weeks ago

It would be easier to disconnect the wifi before starting the old vscode(1.90.2) and set "update.mode": "none".

wy353208214 commented 2 weeks ago

It would be easier to disconnect the wifi before starting the old vscode(1.90.2) and set "update.mode": "none".

i set it to 'manual'

gjsjohnmurray commented 2 weeks ago

@wy353208214 the link you posted is for 1.91.0

Progress towards the release of 1.91.1 can be tracked at https://github.com/microsoft/vscode/issues/221133

illustrious-otter commented 2 weeks ago

Have 1.91.1 working fine on macos 10.15.7 but as soon as I put upgrade back to auto/start it downgrades itself to 1.91.0 ?

tonywoode commented 2 weeks ago

Can users additionally help verify if the following builds based on 1.91.1 address the issue,

Apple Intel Apple Silicon Universal

+1 to this working on Catalina 10.15.7

MyroslavSB commented 2 weeks ago

same issue macOS Big Sur 11.4, rollback to VSCode v1.90 fixed the problem. Also in settings disabled auto update. So far so good.

suhee700 commented 2 weeks ago

Same issue in macOS Big Sur v11.6.5, rollback v1.90(https://code.visualstudio.com/updates/v1_90) and fix.

RoyTynan commented 2 weeks ago

V1.91 on Intel Mac Book Pro running new install of Big Sur 11.7.10. Not installing V1.90 installed ok. In Preferences/Settings disabled auto update, it's working

everm1nd commented 2 weeks ago

Same here. VSCode launch output from console:

➜  MacOS ./Electron
[1656:0710/133403.472349:ERROR:node_bindings.cc(162)] Fatal error in V8: v8::Template::Set Invalid value, must be a primitive or a Template
[0710/133403.698046:WARNING:crash_report_exception_handler.cc(235)] UniversalExceptionRaise: (os/kern) failure (5)
[1]    1656 segmentation fault  ./Electron
[0710/133403.728267:ERROR:directory_reader_posix.cc(43)] opendir /Users/nikitasimakov/Library/Application Support/Code/Crashpad/attachments/369cb1e9-4609-4e22-9356-982964c2b50f: No such file or directory (2)

Version:

➜  MacOS code --version
1.91.0
ea1445cc7016315d0f5728f8e8b12a45dc0a7286
x64

Fixed by rollback to:

1.90.2
5437499feb04f7a586f677b155b039bc2b3669eb
x64

deepak1556 commented 2 weeks ago

Locking the issue again till new release is made, we have enough data to be confident that the fix in https://github.com/microsoft/vscode/issues/219893#issuecomment-2215869269 resolves the issue. I will update here once the build is released. Thanks for your patience.

deepak1556 commented 2 weeks ago

Fix is now available in latest release 1.91.1