search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.56k stars 28.14k forks source link

Light bulb suggestions have inconsistent theming options #219985

Open jmg-duarte opened 4 days ago

jmg-duarte commented 4 days ago

Does this issue occur when all extensions are disabled?: Yes/No

I'm not sure if this is more of a bug or a feature request, but the truth (IMO) is that as it stands, it's inconsistent and it breaks my theme 😅

Steps to reproduce:

  1. Set "editorSuggestWidget.selectedBackground": "#FF0000" so it's clear
  2. Try to use the Light Bulb suggestions

Regular suggestions

Screenshot 2024-07-04 at 16 42 10

Light Bulb

Screenshot 2024-07-04 at 16 42 32

Current state of affairs

In the screenshot above (light bulb) there's "nothing selected" because the light bulb menu uses the colors from quick input which is ok, until you have a background color for quick input that is the same as the selection color for the light bulb.

To me, it makes more sense that the light bulb menu customizations would be the same as the suggestions as they are, well, suggestions too. However, this would probably break existing themes and I have no clue about the VSCode team's policies on that.

A separate theming option like "quickFix.selectedBackground" or similar would make it so that changing it to the suggestions can't break existing themes.

If the team thinks it's more cohesive to use the suggestions, I'm all for it too!

VSCodeTriageBot commented 4 days ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.91.0. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!