microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.22k stars 28.55k forks source link

Window freeze when finding regex #221827

Open Tyriar opened 1 month ago

Tyriar commented 1 month ago

Repro:

  1. Open https://github.com/microsoft/vscode/blob/739f145f893d090d0a6f48ac457cd27cdf674c89/src/vs/workbench/contrib/terminalContrib/suggest/test/browser/recordings/windows11_pwsh_input_ls_complete_ls.ts
  2. Ctrl+f
  3. Alt+r (regex mode)
  4. Type \[.+,.+,.+,\
  5. Type ] 💥 frozen window

image

Tyriar commented 1 month ago

Non freezing regex that mostly accomplished what I was trying to do: \[([^,]+,){3}[^,]+\]

rebornix commented 1 month ago

Currently we don't have a mechanism to prevent a blocking regex.