Open manav014 opened 1 month ago
When trying to search in a Markdown Preview whilst debugging, the code does hit WebViewMainService.findInFrame()
:
https://github.com/microsoft/vscode/blob/709c3d756947c2c275bf90a87a071eca58453851/src/vs/platform/webview/electron-main/webviewMainService.ts#L50-L59
However, frame.findInFrame
is undefined
so it just skips the rest of the function - and this appears to be why it's not working.
Now, according to this issue https://github.com/microsoft/vscode/issues/201176 Microsoft uses a custom build of electron (from https://github.com/microsoft/vscode-electron-prebuilt that is not publicly accessible) for VS Code releases, with a WebFrameMain.FindInFrame()
implementation, so searching works.
The intention seems to be that changes are gradually upstreamed into the main electron repo, but unfortunately the PR for the FindInFrame
stuff is Closed for the time being: https://github.com/electron/electron/pull/28274
Perhaps if we're able to merge the branch from that PR into an updated local build of electron, then we could use it with our vscode for debugging? 🤔
Does this issue occur when all extensions are disabled?: Yes
Type: Bug
I recently build vscode on local with following configuration and last commit being https://github.com/microsoft/vscode/commit/61b242c67f23d24bcb9abb25bcac223547f032bd .
I found that the search functionality is not working for markdown preview. Seems like a recently introduced issue as when I tried to perform the search operation in stable release I was able to search across markdown preview.
Steps to Reproduce:
This bug could be pushed with next release and can cause issues with upcoming stable releases.
PFA: POC video for the issue.
https://github.com/user-attachments/assets/0bb47435-cbc0-4e56-a821-61d59c2db412
Would be great if @mjbvz , you can shed some light here.