search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.13k stars 29.27k forks source link

Git History Graph: enable jumping to associated PR #223043

Open gjsjohnmurray opened 3 months ago

gjsjohnmurray commented 3 months ago

Type: Feature Request

In the screenshot below I'd like to be able to jump to the associated PR on the GH site, perhaps using the context menu.

image

I'm not sure if this would need to be implemented in the bundled Git extension or is more appropriately handled by the GitHub Pull Requests extension (pinging @alexr00)

VS Code version: Code - Insiders 1.92.0-insider (97d1b933ada0ca69bea107f7a89e029991277ccc, 2024-07-22T05:03:41.362Z) OS version: Windows_NT x64 10.0.22631 Modes:

alexr00 commented 3 months ago

Cool idea. @lszomoru is there a menu that GHPR could contribute to for this?

lszomoru commented 3 months ago

There is, but I think that we should chat as I think you would need more information in order to decide when to show the action.

gjsjohnmurray commented 3 months ago

It would be particularly useful when the commit message doesn't give any indication what the change does. Some of the VS Code team commonly use such messages:

image

lszomoru commented 3 months ago

Ideally we should be able to link out to both GitHub issues as well as pull requests.

gjsjohnmurray commented 3 months ago

A plea to @sandy081 to use more informative PR descriptions:

image

sandy081 commented 3 months ago

Definitely! It would be helpful to show the associated issue in the hover.

gjsjohnmurray commented 3 months ago

Definitely! It would be helpful to show the associated issue in the hover.

@sandy081 it will benefit us in other places too if you create your PRs with descriptive titles rather than always "fix #NNN"