microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.59k stars 29.03k forks source link

Profiles editor is not accessible / usable by keyboard #223297

Open hediet opened 2 months ago

hediet commented 2 months ago

Testing #223080

The profiles editor is not usable by keyboard (only by mouse).

I cannot put focus on this widget and use the arrow keys/tab to select an option:

Image

sandy081 commented 2 months ago

It works with tab button for me, can you please double check?

hediet commented 2 months ago

Ah yes, it works indeed with tab, but it seems like the active button uses the focus-border as border without being focused, so you cannot see that it has focus.

vs-code-engineering[bot] commented 2 months ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

hediet commented 2 months ago

Ah yes, it works indeed with tab, but it seems like the active button uses the focus-border as border without being focused, so you cannot see that it has focus.

I do believe that it should be visibly distinguishable if an element has focus or not. While it looks good, I believe we shouldn't use the focused border color as border for an unfocused element.

It is not a high priority issue, but we shouldn't forget about it, especially when this component is used in other places.