microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.98k stars 28.78k forks source link

Visual issue when running apache_beam interactive_runner #223820

Open hierr opened 2 months ago

hierr commented 2 months ago

Type: Bug

I am trying to use apache beam interactive runner (https://beam.apache.org/releases/pydoc/2.29.0/apache_beam.runners.interactive.interactive_beam.html), but when i run interactive_beam.collect() on any PCollection, the backgound of the notebook becomes white and doesn't respect the color themes.

Steps to Reproduce:

  1. pip install apache-beam[interactive]
  2. import interactive_beam from apache_beam.runners.interactive
  3. use interactive_beam.collect on any PCollection. For example:

Screenshot 2024-07-26 012131

VS Code version: Code 1.91.1 (f1e16e1e6214d7c44d078b1f0607b2388f29d729, 2024-07-09T22:06:49.809Z) OS version: Windows_NT x64 10.0.22000 Modes: Unsupported Remote OS version: Linux x64 5.15.153.1-microsoft-standard-WSL2

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 x 2592)| |GPU Status|2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
webgpu: unavailable_software| |Load (avg)|undefined| |Memory (System)|15.84GB (4.44GB free)| |Process Argv|--crash-reporter-id 32760e88-3a50-48bf-a707-61c9458adc22| |Screen Reader|no| |VM|0%| |Item|Value| |---|---| |Remote|WSL: Ubuntu-24.04| |OS|Linux x64 5.15.153.1-microsoft-standard-WSL2| |CPUs|Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 x 0)| |Memory (System)|7.67GB (6.05GB free)| |VM|0%|
Extensions (24) Extension|Author (truncated)|Version ---|---|--- terraform|4op|0.2.5 vscode-great-icons|emm|2.1.105 jupyter-keymap|ms-|1.1.2 remote-ssh|ms-|0.112.0 remote-ssh-edit|ms-|0.86.0 remote-wsl|ms-|0.88.2 remote-explorer|ms-|0.4.3 remote-server|ms-|1.5.2 gitlens|eam|15.2.1 gitlab-workflow|Git|5.0.0 todo-tree|Gru|0.0.226 debugpy|ms-|2024.8.0 isort|ms-|2023.10.1 python|ms-|2024.10.0 vscode-pylance|ms-|2023.10.40 jupyter|ms-|2024.6.0 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.18 vscode-jupyter-cell-tags|ms-|0.1.9 vscode-jupyter-powertoys|ms-|0.1.1 vscode-jupyter-slideshow|ms-|0.1.6 autodocstring|njp|0.6.1 vscode-thunder-client|ran|2.24.13 vscode-yaml|red|1.15.0 (2 theme extensions excluded)
A/B Experiments ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscorecescf:30445987 vscod805cf:30301675 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 vscaac:30438847 c4g48928:30535728 azure-dev_surveyone:30548225 a9j8j154:30646983 962ge761:30959799 pythongtdpath:30769146 welcomedialogc:30910334 pythonnoceb:30805159 asynctok:30898717 pythonregdiag2:30936856 pythonmypyd1:30879173 h48ei257:31000450 pythontbext0:30879054 accentitlementst:30995554 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 dsvsc021:30996838 0ee40948:31013168 pythoncenvpt:31062603 a69g1124:31058053 dvdeprecation:31068756 dwnewjupyter:31046869 newcmakeconfigv2:31071590 impr_priority:31102340 refactorc:31101458 ccpltc:31103427 pythonrstrctxt:31103193 ```
amunger commented 1 month ago

This is caused by the resulting output importing a stylesheet, which sets the background of the body to white, and that is affecting the entire webview:

" <link rel=\"stylesheet\" href=\"https://stackpath.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css\" integrity=\"sha384-Vkoo8x4CGsO3+Hhxv8T/Q5PaXtkKtu6ug5TOeNV6gBiFeWPGFN9MuhOf23Q9Ifjh\" crossorigin=\"anonymous\">\n",

We might just want to mark the style as !important here since changing it in a single output can cause a change like this. @mattbierner - does that sound reasonable? Or would this need to be in a notebook specific location.