search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.23k stars 29.3k forks source link

Add Julia as a shell type in core #224325

Open anthonykim1 opened 3 months ago

anthonykim1 commented 3 months ago

Part of: https://github.com/microsoft/vscode/issues/155530 This should allow clear separation when users attempt to "Terminal: Run Recent Command", as in Julia users will only see Julia commands from VS Code and not those from other shells.

anthonykim1 commented 2 months ago

Verification Steps:

  1. Install and Julia and Screenshot 2024-08-26 at 3 18 32 PM
  2. Head over to command palette (launch via ctrl/cmd + shift + p) and press on Julia: Start REPL or Julia: Restart REPL Screenshot 2024-08-26 at 3 19 11 PM
  3. Type in some Julia command in Terminal
  4. Open command palette again and click on "Terminal: Run Recent Command"
  5. Observe you only see command from Julia shell and no commands from other shell.
amunger commented 2 months ago

the Terminal: Run recent command command just no-ops for me if I have a Julia REPL running, even after running commands in there. I don't see any errors in the dev tools.

Recording 2024-08-28 at 10 03 03

anthonykim1 commented 2 months ago

@amunger What is exact name of the julia executable in your windows machine? Is it something that deviates from "julia.exe"?

amunger commented 2 months ago

from julia logs, it looks like it is using "julia.exe"

Trying to locate Julia binary...
Juliaup not found, locating Julia by other means.
The identified Julia executable is "julia.exe" with args "".